[GitHub] [couchdb] iilyak opened a new pull request #2985: Fix auth injection in test helper

[GitBox <gi...@apache.org>]

iilyak opened a new pull request #2985:
URL: https://github.com/apache/couchdb/pull/2985


   
   ## Overview
   
   Previously the auth was injected unconidtionally. There were two problems:
   
   1. no way to specify `basic_auth` credentials
   2. no way to disable injection
   
   Due to #2 it was impossible to use other user than hardcoded `adm` in `Couch.login/3`.
   
   ## Testing recommendations
   
   The following should be sufficient to test for regressions
   
   ```
   make exunit tests=src/chttpd/test/exunit/pagination_test.exs
   ```
   
   ## Related Issues or Pull Requests
   
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak merged pull request #2985: Fix auth injection in test helper

[GitBox <gi...@apache.org>]

iilyak merged pull request #2985:
URL: https://github.com/apache/couchdb/pull/2985


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org