[GitHub] [netbeans] mbien commented on a diff in pull request #5107: enable some important sounding java tests

[GitBox <gi...@apache.org>]

mbien commented on code in PR #5107:
URL: https://github.com/apache/netbeans/pull/5107#discussion_r1047673049


##########
java/spi.java.hints/test/unit/src/org/netbeans/modules/java/hints/spiimpl/UtilitiesTest.java:
##########
@@ -366,7 +366,7 @@ public void testPositionsForCorrectStatement() throws Exception {
         assertTrue(errors.isEmpty());
         assertPositions(result, positions[0], code, "assert true;", "true");
     }
-
+/* TODO: fails
     public void testCasePattern() throws Exception {

Review Comment:
   this one failed



##########
java/java.lexer/nbproject/project.properties:
##########
@@ -21,6 +21,11 @@ javac.source=1.8
 javadoc.title=Java Lexer API
 javadoc.apichanges=${basedir}/apichanges.xml
 
+test.config.default.excludes=\
+    **/JavaLexerPerformanceTest.class,\
+    **/JavaFlyTokensTest.class,\
+    **/JavaTokenDumpTest.class

Review Comment:
   those `java.lexer` tests require a test file (looks like it was the source code of JComponent) which probably has been removed before the code was donated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists