You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/06/24 06:38:48 UTC
[GitHub] [carbondata] nihal0107 opened a new pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
nihal0107 opened a new pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164
### Why is this PR needed?
Documentation changes were not handled in PR [4116](https://github.com/apache/carbondata/pull/4116)
### What changes were proposed in this PR?
Added missing documentation.
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#discussion_r665055681
##########
File path: docs/index/secondary-index-guide.md
##########
@@ -118,9 +118,11 @@ also load data to the SI table with the same number of segments as the main tabl
the main table will also load data to the SI table.
**NOTE**:
- * In case of data load failure to the SI table, then we make the SI table disable by setting a hive serde
- property. The subsequent main table load will load the old failed loads along with current load and
- makes the SI table enable and available for query.
+ * In case of data load failure to the SI table, segments of main table and SI table will not be in sync.
+ In this scenario the subsequent query pruning will be performed at segment level. It means all successful SI segment
Review comment:
```suggestion
In this scenario the subsequent query pruning will be performed at segment level. It means all successful SI segments
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-874750727
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3908/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a change in pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on a change in pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#discussion_r665089655
##########
File path: docs/index/secondary-index-guide.md
##########
@@ -118,9 +118,11 @@ also load data to the SI table with the same number of segments as the main tabl
the main table will also load data to the SI table.
**NOTE**:
- * In case of data load failure to the SI table, then we make the SI table disable by setting a hive serde
- property. The subsequent main table load will load the old failed loads along with current load and
- makes the SI table enable and available for query.
+ * In case of data load failure to the SI table, segments of main table and SI table will not be in sync.
Review comment:
can we give one example for this scenario for easy understanding ?
ex:
segment 1 loaded successfully to maintable and SI
segment 2 loaded successfully to maintable and SI
segment 3 failed to load.
show segment differences between maintable and SI table.
so in this case for segment 1 and segment 2 pruned by SI and segment 3 filter with help of maintable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on a change in pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on a change in pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#discussion_r665106662
##########
File path: docs/index/secondary-index-guide.md
##########
@@ -118,9 +118,11 @@ also load data to the SI table with the same number of segments as the main tabl
the main table will also load data to the SI table.
**NOTE**:
- * In case of data load failure to the SI table, then we make the SI table disable by setting a hive serde
- property. The subsequent main table load will load the old failed loads along with current load and
- makes the SI table enable and available for query.
+ * In case of data load failure to the SI table, segments of main table and SI table will not be in sync.
Review comment:
As discussed already examples present in the design doc which present in CARBONDATA-4162.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-867651877
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5629/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] brijoobopanna commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
brijoobopanna commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-874646044
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on a change in pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on a change in pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#discussion_r665065409
##########
File path: docs/index/secondary-index-guide.md
##########
@@ -118,9 +118,11 @@ also load data to the SI table with the same number of segments as the main tabl
the main table will also load data to the SI table.
**NOTE**:
- * In case of data load failure to the SI table, then we make the SI table disable by setting a hive serde
- property. The subsequent main table load will load the old failed loads along with current load and
- makes the SI table enable and available for query.
+ * In case of data load failure to the SI table, segments of main table and SI table will not be in sync.
+ In this scenario the subsequent query pruning will be performed at segment level. It means all successful SI segment
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-874783320
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/55/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875354789
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875468287
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875436063
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5662/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-867654538
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3886/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-867557027
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5626/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-867665536
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/33/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-867573488
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/30/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875454728
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3918/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-867546754
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875445647
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/66/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-874754047
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5651/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] brijoobopanna commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
brijoobopanna commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-874646044
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875291933
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875311681
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-867566074
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #4164: [CARBONDATA-4232] Add missing doc change for secondary index.
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4164:
URL: https://github.com/apache/carbondata/pull/4164#issuecomment-875313705
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org