You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2016/06/16 04:49:20 UTC
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1490
STORM-1902 (1.x): add a simple & flexible FileNameFormat for storm-hdfs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-1902-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1490
----
commit baebb4fd60d11a0a622443ce077c427d6c12978c
Author: vesense <be...@163.com>
Date: 2016-06-16T04:45:24Z
STORM-1902: add a simple & flexible FileNameFormat for storm-hdfs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1490
+1 Thanks for following up so quickly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/1490#discussion_r67519979
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/format/TestSimpleFileNameFormat.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.hdfs.bolt.format;
+
+import java.net.UnknownHostException;
+import java.text.SimpleDateFormat;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.utils.Utils;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestSimpleFileNameFormat {
+
+ @Test
+ public void testDefaults() {
+ SimpleFileNameFormat format = new SimpleFileNameFormat();
+ format.prepare(null, createTopologyContext());
+ String path = format.getPath();
+ String name = format.getName(1, System.currentTimeMillis());
+
+ Assert.assertEquals("/storm", path);
+ String now = new SimpleDateFormat("yyyyMMddHHmmss").format(System.currentTimeMillis());
+ Assert.assertEquals(now+".1.txt", name);
--- End diff --
This is a nit, but this test might occasionally fail since the time is taken at two different points which might resolve to different seconds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/1490#discussion_r67370184
--- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/format/SimpleFileNameFormat.java ---
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.hdfs.bolt.format;
+
+import java.net.UnknownHostException;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import java.util.Map;
+
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.utils.Utils;
+
+public class SimpleFileNameFormat implements FileNameFormat {
+
+ private static final long serialVersionUID = 1L;
+
+ private String componentId;
+ private int taskId;
+ private String host;
+ private String path = "/storm";
+ private String name = "$TIME.$NUM.txt";
+ private String timeFormat = "yyyyMMddHHmmss";
+
+ @Override
+ public String getName(long rotation, long timeStamp) {
+ // compile parameters
+ SimpleDateFormat dateFormat = new SimpleDateFormat(timeFormat);
+ String ret = name
+ .replace("$TIME", dateFormat.format(new Date(timeStamp)))
+ .replace("$NUM", String.valueOf(rotation))
+ .replace("$HOST", host)
+ .replace("$COMPONENT", componentId)
+ .replace("$TASK", String.valueOf(taskId));
+ return ret;
+ }
+
+ @Override
+ public String getPath() {
+ return path;
+ }
+
+ @SuppressWarnings("unchecked")
+ @Override
+ public void prepare(Map conf, TopologyContext topologyContext) {
+ this.componentId = topologyContext.getThisComponentId();
+ this.taskId = topologyContext.getThisTaskId();
+ try {
+ this.host = Utils.localHostname();
+ } catch (UnknownHostException e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ public SimpleFileNameFormat withPath(String path) {
+ this.path = path;
+ return this;
+ }
+
+ /**
+ * support parameters:<br/>
+ * $TIME - current time. use <code>withTimeFormat</code> to format.<br/>
+ * $NUM - rotation number<br/>
+ * $HOST - local host name<br/>
+ * $COMPONENT - component id<br/>
+ * $TASK - task id<br/>
+ *
+ * @param name
+ * file name
+ * @return
+ */
+ public SimpleFileNameFormat withName(String name) {
+ this.name = name;
+ return this;
+ }
+
+ public SimpleFileNameFormat withTimeFormat(String timeFormat) {
+ this.timeFormat = timeFormat;
--- End diff --
How about constructing a SimpleDateFormat here to validate the timeFormat string? If it's an invalid string, better to catch it here at setup time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1490#discussion_r67465924
--- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/format/SimpleFileNameFormat.java ---
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.hdfs.bolt.format;
+
+import java.net.UnknownHostException;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import java.util.Map;
+
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.utils.Utils;
+
+public class SimpleFileNameFormat implements FileNameFormat {
+
+ private static final long serialVersionUID = 1L;
+
+ private String componentId;
+ private int taskId;
+ private String host;
+ private String path = "/storm";
+ private String name = "$TIME.$NUM.txt";
+ private String timeFormat = "yyyyMMddHHmmss";
+
+ @Override
+ public String getName(long rotation, long timeStamp) {
+ // compile parameters
+ SimpleDateFormat dateFormat = new SimpleDateFormat(timeFormat);
+ String ret = name
+ .replace("$TIME", dateFormat.format(new Date(timeStamp)))
+ .replace("$NUM", String.valueOf(rotation))
+ .replace("$HOST", host)
+ .replace("$COMPONENT", componentId)
+ .replace("$TASK", String.valueOf(taskId));
+ return ret;
+ }
+
+ @Override
+ public String getPath() {
+ return path;
+ }
+
+ @SuppressWarnings("unchecked")
+ @Override
+ public void prepare(Map conf, TopologyContext topologyContext) {
+ this.componentId = topologyContext.getThisComponentId();
+ this.taskId = topologyContext.getThisTaskId();
+ try {
+ this.host = Utils.localHostname();
+ } catch (UnknownHostException e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ public SimpleFileNameFormat withPath(String path) {
+ this.path = path;
+ return this;
+ }
+
+ /**
+ * support parameters:<br/>
+ * $TIME - current time. use <code>withTimeFormat</code> to format.<br/>
+ * $NUM - rotation number<br/>
+ * $HOST - local host name<br/>
+ * $COMPONENT - component id<br/>
+ * $TASK - task id<br/>
+ *
+ * @param name
+ * file name
+ * @return
+ */
+ public SimpleFileNameFormat withName(String name) {
+ this.name = name;
+ return this;
+ }
+
+ public SimpleFileNameFormat withTimeFormat(String timeFormat) {
+ this.timeFormat = timeFormat;
--- End diff --
Agree with you. Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1490#discussion_r68013918
--- Diff: external/storm-hdfs/README.md ---
@@ -159,6 +159,8 @@ For example:
By default, prefix is empty and extenstion is ".txt".
+The provided `org.apache.storm.hdfs.format.SimpleFileNameFormat` is flexible, supports parameters such as `$TIME` `$NUM` `$HOST` etc.
--- End diff --
It may be better to elaborate how to use so that users don't need to look at javadoc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/1490#discussion_r67520068
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/format/TestSimpleFileNameFormat.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.hdfs.bolt.format;
+
+import java.net.UnknownHostException;
+import java.text.SimpleDateFormat;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.utils.Utils;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestSimpleFileNameFormat {
+
+ @Test
+ public void testDefaults() {
+ SimpleFileNameFormat format = new SimpleFileNameFormat();
+ format.prepare(null, createTopologyContext());
+ String path = format.getPath();
+ String name = format.getName(1, System.currentTimeMillis());
+
+ Assert.assertEquals("/storm", path);
+ String now = new SimpleDateFormat("yyyyMMddHHmmss").format(System.currentTimeMillis());
+ Assert.assertEquals(now+".1.txt", name);
+ }
+
+ @Test
+ public void testParameters() {
+ SimpleFileNameFormat format = new SimpleFileNameFormat()
+ .withName("$TIME.$HOST.$COMPONENT.$TASK.$NUM.txt")
+ .withPath("/mypath")
+ .withTimeFormat("yyyy-MM-dd HH:mm:ss");
+ format.prepare(null, createTopologyContext());
+ String path = format.getPath();
+ String name = format.getName(1, System.currentTimeMillis());
+
+ Assert.assertEquals("/mypath", path);
+ String now = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss").format(System.currentTimeMillis());
--- End diff --
Same comment as above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1490#discussion_r67531803
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/format/TestSimpleFileNameFormat.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.hdfs.bolt.format;
+
+import java.net.UnknownHostException;
+import java.text.SimpleDateFormat;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.utils.Utils;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestSimpleFileNameFormat {
+
+ @Test
+ public void testDefaults() {
+ SimpleFileNameFormat format = new SimpleFileNameFormat();
+ format.prepare(null, createTopologyContext());
+ String path = format.getPath();
+ String name = format.getName(1, System.currentTimeMillis());
+
+ Assert.assertEquals("/storm", path);
+ String now = new SimpleDateFormat("yyyyMMddHHmmss").format(System.currentTimeMillis());
+ Assert.assertEquals(now+".1.txt", name);
+ }
+
+ @Test
+ public void testParameters() {
+ SimpleFileNameFormat format = new SimpleFileNameFormat()
+ .withName("$TIME.$HOST.$COMPONENT.$TASK.$NUM.txt")
+ .withPath("/mypath")
+ .withTimeFormat("yyyy-MM-dd HH:mm:ss");
+ format.prepare(null, createTopologyContext());
+ String path = format.getPath();
+ String name = format.getName(1, System.currentTimeMillis());
+
+ Assert.assertEquals("/mypath", path);
+ String now = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss").format(System.currentTimeMillis());
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the issue:
https://github.com/apache/storm/pull/1490
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1490
@dossett Updated and rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1490
Thanks @dossett for your review. Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1490
The change looks good. I just would like to add kind explanation to letting users know and use new feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1490
Close commit message not against master seems not work.
@vesense PR is merged to 1.x-branch. Could you please close this? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1490#discussion_r67531746
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/format/TestSimpleFileNameFormat.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.hdfs.bolt.format;
+
+import java.net.UnknownHostException;
+import java.text.SimpleDateFormat;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.utils.Utils;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestSimpleFileNameFormat {
+
+ @Test
+ public void testDefaults() {
+ SimpleFileNameFormat format = new SimpleFileNameFormat();
+ format.prepare(null, createTopologyContext());
+ String path = format.getPath();
+ String name = format.getName(1, System.currentTimeMillis());
+
+ Assert.assertEquals("/storm", path);
+ String now = new SimpleDateFormat("yyyyMMddHHmmss").format(System.currentTimeMillis());
+ Assert.assertEquals(now+".1.txt", name);
--- End diff --
nice catch. fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the issue:
https://github.com/apache/storm/pull/1490
Some unit tests would be very helpful, especially to verify the substitution logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...
Posted by vesense <gi...@git.apache.org>.
Github user vesense closed the pull request at:
https://github.com/apache/storm/pull/1490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the issue:
https://github.com/apache/storm/pull/1490
Two minor nits noted inline, but I am otherwise +1. Test failures look unrelated.
This is a nice addition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---