[jira] [Resolved] (NUTCH-1883) bin/crawl: use function to run bin/nutch and check exit value

["Sebastian Nagel (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NUTCH-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Nagel resolved NUTCH-1883.
------------------------------------
    Resolution: Fixed

Patch v2 committed to trunk and 2.x, r1638203.

> bin/crawl: use function to run bin/nutch and check exit value
> -------------------------------------------------------------
>
>                 Key: NUTCH-1883
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1883
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.9, 2.2.1
>            Reporter: Sebastian Nagel
>            Assignee: Sebastian Nagel
>            Priority: Minor
>             Fix For: 2.3, 1.10
>
>         Attachments: NUTCH-1883-2x-v1.patch, NUTCH-1883-trunk-v1.patch, NUTCH-1883-trunk-v2.patch, NUTCH-1883-trunk-v2.patch
>
>
> In bin/crawl for every Nutch command the exit value is checked explicitly:
> {code}
> "$bin/nutch" ...
> RETCODE=$?
> if [ $RETCODE -ne 0 ] 
> then exit $RETCODE 
> fi
> {code}
> This could be simplified by calling bin/nutch from one function which does the check. The function could also echo the command, show an error message, etc. The main advantage is short and clear code. In case a special treatment of exit values is required (cf. NUTCH-1829) we still could call bin/nutch directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)