You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by sh...@apache.org on 2020/06/05 14:59:15 UTC
[unomi] branch UNOMI-341-refactoring-graphql-servicemanager
updated: UNOMI-341 - Refactor ServiceManager - Use vars to avoid repeated
calls to bundleContext
This is an automated email from the ASF dual-hosted git repository.
shuber pushed a commit to branch UNOMI-341-refactoring-graphql-servicemanager
in repository https://gitbox.apache.org/repos/asf/unomi.git
The following commit(s) were added to refs/heads/UNOMI-341-refactoring-graphql-servicemanager by this push:
new af42899 UNOMI-341 - Refactor ServiceManager - Use vars to avoid repeated calls to bundleContext
af42899 is described below
commit af4289939b8690629249289315b312b79b7e1586
Author: Serge Huber <sh...@apache.org>
AuthorDate: Fri Jun 5 16:59:09 2020 +0200
UNOMI-341 - Refactor ServiceManager
- Use vars to avoid repeated calls to bundleContext
---
.../apache/unomi/graphql/commands/list/AddProfileToListCommand.java | 5 +++--
.../unomi/graphql/commands/list/RemoveProfileFromListCommand.java | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/AddProfileToListCommand.java b/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/AddProfileToListCommand.java
index 285b566..4c7e69e 100644
--- a/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/AddProfileToListCommand.java
+++ b/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/AddProfileToListCommand.java
@@ -54,7 +54,8 @@ public class AddProfileToListCommand extends BaseCommand<CDPList> {
return null;
}
- final Profile profile = serviceManager.getService(ProfileService.class).load(profileIDInput.getId());
+ ProfileService profileService = serviceManager.getService(ProfileService.class);
+ final Profile profile = profileService.load(profileIDInput.getId());
if (profile == null) {
return null;
@@ -66,7 +67,7 @@ public class AddProfileToListCommand extends BaseCommand<CDPList> {
.build();
if (serviceManager.getService(EventService.class).send(event) == EventService.PROFILE_UPDATED) {
- serviceManager.getService(ProfileService.class).save(event.getProfile());
+ profileService.save(event.getProfile());
}
return new CDPList(UserListConverter.convertToUnomiList(userList));
diff --git a/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/RemoveProfileFromListCommand.java b/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/RemoveProfileFromListCommand.java
index 18b0906..1415bb7 100644
--- a/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/RemoveProfileFromListCommand.java
+++ b/graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/commands/list/RemoveProfileFromListCommand.java
@@ -50,7 +50,8 @@ public class RemoveProfileFromListCommand extends BaseCommand<Boolean> {
return null;
}
- final Profile profile = serviceManager.getService(ProfileService.class).load(profileIDInput.getId());
+ ProfileService profileService = serviceManager.getService(ProfileService.class);
+ final Profile profile = profileService.load(profileIDInput.getId());
if (profile == null) {
return null;
@@ -64,7 +65,7 @@ public class RemoveProfileFromListCommand extends BaseCommand<Boolean> {
int eventCode = serviceManager.getService(EventService.class).send(event);
if (eventCode == EventService.PROFILE_UPDATED) {
- serviceManager.getService(ProfileService.class).save(event.getProfile());
+ profileService.save(event.getProfile());
return true;
}