You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lokeshj1703 (via GitHub)" <gi...@apache.org> on 2023/03/08 10:53:25 UTC
[GitHub] [hudi] lokeshj1703 opened a new pull request, #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
lokeshj1703 opened a new pull request, #8128:
URL: https://github.com/apache/hudi/pull/8128
### Change Logs
See https://github.com/apache/hudi/pull/7912/files for more details
Configs in scope:
DYNAMODB_LOCK_TABLE_NAME
DYNAMODB_LOCK_TABLE_CREATION_TIMEOUT
ARCHIVE_BEYOND_SAVEPOINT
PRESERVE_COMMIT_METADATA (in multiple classes)
BLOOM_INDEX_UPDATE_PARTITION_PATH_ENABLE
SIMPLE_INDEX_UPDATE_PARTITION_PATH_ENABLE
BUCKET_INDEX_NUM_BUCKETS
BUCKET_INDEX_MAX_NUM_BUCKETS
BULKINSERT_ARE_PARTITIONER_RECORDS_SORTED
BULKINSERT_INPUT_DATA_SCHEMA_DDL ?
Lock Configs: LOCK_ACQUIRE_RETRY_MAX_WAIT_TIME_IN_MILLIS
FILESYSTEM_LOCK_EXPIRE
ZK_BASE_PATH
SPILLABLE_MAP_BASE_PATH
CALLBACK_HTTP_TIMEOUT_IN_SECONDS
ROLLBACK_USING_MARKERS_ENABLE
WRITE_EXECUTOR_DISRUPTOR_BUFFER_LIMIT_BYTES ?
ALLOW_MULTI_WRITE_ON_SAME_INSTANT_ENABLE ?
AUTO_ADJUST_LOCK_CONFIGS ?
SKIP_DEFAULT_PARTITION_VALIDATION
### Impact
Some of the configs are being removed after review.
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1461617350
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 8c39806bc06d180eb8c07b0879bc9fad3c9cc170 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1489845427
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
}, {
"hash" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987",
"triggerID" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958)
* b89c0f1e35a2ca897ce5e123604401955cc7240d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1497565084
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
}, {
"hash" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093",
"triggerID" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"triggerType" : "PUSH"
}, {
"hash" : "310d820345a867c6c32bc312243a5e62f681e908",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16139",
"triggerID" : "310d820345a867c6c32bc312243a5e62f681e908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 310d820345a867c6c32bc312243a5e62f681e908 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1134765337
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -297,21 +295,15 @@ private FlinkOptions() {
.booleanType()
.defaultValue(false)// default read as batch
.withDescription("Whether to skip compaction instants and avoid reading compacted base files for streaming read to improve read performance.\n"
- + "There are two cases that this option can be used to avoid reading duplicates:\n"
- + "1) you are definitely sure that the consumer reads [faster than/completes before] any compaction instants "
- + "when " + HoodieCompactionConfig.PRESERVE_COMMIT_METADATA.key() + " is set to false.\n"
- + "2) changelog mode is enabled, this option is a solution to keep data integrity");
+ + "This option can be used to avoid reading duplicates when changelog mode is enabled, it is a solution to keep data integrity\n");
Review Comment:
Yeah, it's okey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1490139339
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
}, {
"hash" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987",
"triggerID" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b89c0f1e35a2ca897ce5e123604401955cc7240d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1136097088
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -69,6 +69,10 @@ public class HoodieIndexConfig extends HoodieConfig {
private static final Logger LOG = LogManager.getLogger(HoodieIndexConfig.class);
+ public static final boolean DEFAULT_BLOOM_INDEX_UPDATE_PARTITION_PATH = true;
+ public static final boolean DEFAULT_SIMPLE_INDEX_UPDATE_PARTITION_PATH = true;
+
+
Review Comment:
We'll keep the configs: `hoodie.bloom.index.update.partition.path` and `hoodie.simple.index.update.partition.path`. Some users may still want them to be `false`.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java:
##########
@@ -133,7 +133,7 @@ public class ClusteringOperator extends TableStreamOperator<ClusteringCommitEven
public ClusteringOperator(Configuration conf, RowType rowType) {
this.conf = conf;
- this.preserveHoodieMetadata = conf.getBoolean(HoodieClusteringConfig.PRESERVE_COMMIT_METADATA.key(), HoodieClusteringConfig.PRESERVE_COMMIT_METADATA.defaultValue());
+ this.preserveHoodieMetadata = HoodieClusteringConfig.DEFAULT_PRESERVE_COMMIT_METADATA;
Review Comment:
Fixed.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -199,13 +199,8 @@ private static Stream<Arguments> populateMetaFieldsParams() {
return Arrays.stream(new Boolean[][] {{true}, {false}}).map(Arguments::of);
}
- private static Stream<Arguments> populateMetaFieldsAndPreserveMetadataParams() {
- return Arrays.stream(new Boolean[][] {
- {true, true},
- {false, true},
- {true, false},
- {false, false}
- }).map(Arguments::of);
+ private static Stream<Arguments> populateMetaFields() {
Review Comment:
This method is no longer needed and we can reuse `populateMetaFieldsParams()`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##########
@@ -48,6 +48,8 @@
+ "which optimizes the storage layout for better query performance by sorting and sizing data files.")
public class HoodieClusteringConfig extends HoodieConfig {
+ public static final boolean DEFAULT_PRESERVE_COMMIT_METADATA = true;
Review Comment:
These are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1478651197
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
}, {
"hash" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836",
"triggerID" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 2bfe86334532ea18748adbb7ff7481fa146b81fd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1152831160
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
Yeah. I had my doubts about this as well. I made an attempt to revert to old behavior. Please let me know if it looks okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1461375375
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 4b4cba35e91b74dcca764894fdbcb17ad1fa197d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622)
* 8c39806bc06d180eb8c07b0879bc9fad3c9cc170 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1460075750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 40cd6e8ec745a72e56deea3f76ac80a04f5a5e47 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619)
* 4b4cba35e91b74dcca764894fdbcb17ad1fa197d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1470982009
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* b4c5a2a6026645077caaa012ccbf234fbece43ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720)
* 5331412a3bfb887c22641ee6bbcb7307498fb02b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1460003338
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 40cd6e8ec745a72e56deea3f76ac80a04f5a5e47 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1152611317
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
sorry, default value for preserveCommitMetadata is true. but for hfile(MDT), meta fields are disable and hence we need to re-create and not preserve. can you help me clarify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1470986502
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* b4c5a2a6026645077caaa012ccbf234fbece43ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720)
* 5331412a3bfb887c22641ee6bbcb7307498fb02b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1153954231
##########
hudi-aws/src/main/java/org/apache/hudi/config/DynamoDbBasedLockConfig.java:
##########
@@ -46,7 +46,7 @@ public class DynamoDbBasedLockConfig extends HoodieConfig {
public static final ConfigProperty<String> DYNAMODB_LOCK_TABLE_NAME = ConfigProperty
.key(DYNAMODB_BASED_LOCK_PROPERTY_PREFIX + "table")
- .noDefaultValue()
+ .defaultValue("hudi_locks")
Review Comment:
wouldn't this result in diff tables using same lock ?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java:
##########
@@ -114,7 +116,7 @@ public HoodieCreateHandle(HoodieWriteConfig config, String instantTime, HoodieTa
public HoodieCreateHandle(HoodieWriteConfig config, String instantTime, HoodieTable<T, I, K, O> hoodieTable,
String partitionPath, String fileId, Map<String, HoodieRecord<T>> recordMap,
TaskContextSupplier taskContextSupplier) {
- this(config, instantTime, hoodieTable, partitionPath, fileId, taskContextSupplier, config.isPreserveHoodieCommitMetadataForCompaction());
+ this(config, instantTime, hoodieTable, partitionPath, fileId, taskContextSupplier, !HoodieTableMetadata.isMetadataTable(config.getBasePath()));
Review Comment:
lets add java docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lokeshj1703 commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1486642399
`TestHoodieSparkMergeOnReadTableIncrementalRead` was failing because it used `SparkClientFunctionalTestHarness` and had disabled preseve commit metadata for compaction. But the change in PR sets it to true. The test was checking for the commit field.
`TestUpdateSchemaEvolution` was failing because the create handle was using compaction preserve config to decide it metadata field is populated while writing the record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1152831160
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
Yeah. I had my doubts about this as well. I made an attempt to revert to old behavior. Please let me know if it looks okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1492028896
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
}, {
"hash" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987",
"triggerID" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"triggerType" : "PUSH"
}, {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1492854094
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8128:
URL: https://github.com/apache/hudi/pull/8128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1497302018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
}, {
"hash" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093",
"triggerID" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"triggerType" : "PUSH"
}, {
"hash" : "310d820345a867c6c32bc312243a5e62f681e908",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "310d820345a867c6c32bc312243a5e62f681e908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fca6d63c9ef24cdd0cfe30060a58430d035e0664 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093)
* 310d820345a867c6c32bc312243a5e62f681e908 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1497311048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
}, {
"hash" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093",
"triggerID" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"triggerType" : "PUSH"
}, {
"hash" : "310d820345a867c6c32bc312243a5e62f681e908",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16139",
"triggerID" : "310d820345a867c6c32bc312243a5e62f681e908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fca6d63c9ef24cdd0cfe30060a58430d035e0664 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093)
* 310d820345a867c6c32bc312243a5e62f681e908 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1468804536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 8c39806bc06d180eb8c07b0879bc9fad3c9cc170 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630)
* 2c0b7bd0abb02365cca9cb249a104244e1a5fa1d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719)
* b4c5a2a6026645077caaa012ccbf234fbece43ef UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1478522849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
}, {
"hash" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836",
"triggerID" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756)
* 2bfe86334532ea18748adbb7ff7481fa146b81fd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1486618723
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
}, {
"hash" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836",
"triggerID" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"triggerType" : "PUSH"
}, {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 2bfe86334532ea18748adbb7ff7481fa146b81fd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836)
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1486896622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
}, {
"hash" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836",
"triggerID" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"triggerType" : "PUSH"
}, {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1491640538
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
}, {
"hash" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987",
"triggerID" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"triggerType" : "PUSH"
}, {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b89c0f1e35a2ca897ce5e123604401955cc7240d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987)
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1489423398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1491650454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
}, {
"hash" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987",
"triggerID" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"triggerType" : "PUSH"
}, {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b89c0f1e35a2ca897ce5e123604401955cc7240d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15987)
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1152831160
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
Yeah. I had my doubts about this as well. I made an attempt to revert to old behavior. Please let me know if it looks okay. I have replaced the check for `isPreserveHoodieCommitMetadataForCompaction` with `!HoodieTableMetadata.isMetadataTable(config.getBasePath())` so that preserve is disabled for MDT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1492841689
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1492840416
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1468815194
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 2c0b7bd0abb02365cca9cb249a104244e1a5fa1d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719)
* b4c5a2a6026645077caaa012ccbf234fbece43ef Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1144191740
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
What is the background to bring back the metadata fields for MDT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1489836330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
}, {
"hash" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b89c0f1e35a2ca897ce5e123604401955cc7240d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958)
* b89c0f1e35a2ca897ce5e123604401955cc7240d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1489414169
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1459994103
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1460011592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 40cd6e8ec745a72e56deea3f76ac80a04f5a5e47 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619)
* 4b4cba35e91b74dcca764894fdbcb17ad1fa197d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1478513128
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
}, {
"hash" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756)
* 2bfe86334532ea18748adbb7ff7481fa146b81fd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1471191739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 5331412a3bfb887c22641ee6bbcb7307498fb02b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1460052178
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 40cd6e8ec745a72e56deea3f76ac80a04f5a5e47 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619)
* 4b4cba35e91b74dcca764894fdbcb17ad1fa197d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1469046890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* b4c5a2a6026645077caaa012ccbf234fbece43ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1489470556
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15958)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1494283433
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
}, {
"hash" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093",
"triggerID" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018)
* fca6d63c9ef24cdd0cfe30060a58430d035e0664 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1494270638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
}, {
"hash" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0b1d2eb5f656f064748ae84b2411a176a459cf8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018)
* fca6d63c9ef24cdd0cfe30060a58430d035e0664 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1494885024
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16018",
"triggerID" : "f0b1d2eb5f656f064748ae84b2411a176a459cf8",
"triggerType" : "PUSH"
}, {
"hash" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093",
"triggerID" : "fca6d63c9ef24cdd0cfe30060a58430d035e0664",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fca6d63c9ef24cdd0cfe30060a58430d035e0664 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16093)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1472429436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 5331412a3bfb887c22641ee6bbcb7307498fb02b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737)
* ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1486608002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
}, {
"hash" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836",
"triggerID" : "2bfe86334532ea18748adbb7ff7481fa146b81fd",
"triggerType" : "PUSH"
}, {
"hash" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7b10b136661325194a7edf2d7b2d9526a83a2e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 2bfe86334532ea18748adbb7ff7481fa146b81fd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15836)
* a7b10b136661325194a7edf2d7b2d9526a83a2e8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1133478509
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -69,6 +69,10 @@ public class HoodieIndexConfig extends HoodieConfig {
private static final Logger LOG = LogManager.getLogger(HoodieIndexConfig.class);
+ public static final boolean DEFAULT_BLOOM_INDEX_UPDATE_PARTITION_PATH = true;
+ public static final boolean DEFAULT_SIMPLE_INDEX_UPDATE_PARTITION_PATH = true;
+
+
Review Comment:
We don't need the variables and we can assume that the default behavior reflects these.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
Have you audited the code path to see there's no behavior change for metadata writing?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -199,13 +199,8 @@ private static Stream<Arguments> populateMetaFieldsParams() {
return Arrays.stream(new Boolean[][] {{true}, {false}}).map(Arguments::of);
}
- private static Stream<Arguments> populateMetaFieldsAndPreserveMetadataParams() {
- return Arrays.stream(new Boolean[][] {
- {true, true},
- {false, true},
- {true, false},
- {false, false}
- }).map(Arguments::of);
+ private static Stream<Arguments> populateMetaFields() {
Review Comment:
nit: rename to `populateMetaFieldsParams`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##########
@@ -48,6 +48,8 @@
+ "which optimizes the storage layout for better query performance by sorting and sizing data files.")
public class HoodieClusteringConfig extends HoodieConfig {
+ public static final boolean DEFAULT_PRESERVE_COMMIT_METADATA = true;
Review Comment:
We don't need the variable and we can assume that the default behavior reflects this. Similar for the compaction.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -297,21 +295,15 @@ private FlinkOptions() {
.booleanType()
.defaultValue(false)// default read as batch
.withDescription("Whether to skip compaction instants and avoid reading compacted base files for streaming read to improve read performance.\n"
- + "There are two cases that this option can be used to avoid reading duplicates:\n"
- + "1) you are definitely sure that the consumer reads [faster than/completes before] any compaction instants "
- + "when " + HoodieCompactionConfig.PRESERVE_COMMIT_METADATA.key() + " is set to false.\n"
- + "2) changelog mode is enabled, this option is a solution to keep data integrity");
+ + "This option can be used to avoid reading duplicates when changelog mode is enabled, it is a solution to keep data integrity\n");
Review Comment:
@danny0405 compaction always preserves the commit metadata by default and now we make it the only behavior to avoid corruption. I assume this is ok for Flink too. Could you confirm it?
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java:
##########
@@ -133,7 +133,7 @@ public class ClusteringOperator extends TableStreamOperator<ClusteringCommitEven
public ClusteringOperator(Configuration conf, RowType rowType) {
this.conf = conf;
- this.preserveHoodieMetadata = conf.getBoolean(HoodieClusteringConfig.PRESERVE_COMMIT_METADATA.key(), HoodieClusteringConfig.PRESERVE_COMMIT_METADATA.defaultValue());
+ this.preserveHoodieMetadata = HoodieClusteringConfig.DEFAULT_PRESERVE_COMMIT_METADATA;
Review Comment:
nit: we don't need this and we can simplify `this.rowType` below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1468793893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 8c39806bc06d180eb8c07b0879bc9fad3c9cc170 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630)
* 2c0b7bd0abb02365cca9cb249a104244e1a5fa1d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1472630415
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1472411195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15630",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
}, {
"hash" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15719",
"triggerID" : "2c0b7bd0abb02365cca9cb249a104244e1a5fa1d",
"triggerType" : "PUSH"
}, {
"hash" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15720",
"triggerID" : "b4c5a2a6026645077caaa012ccbf234fbece43ef",
"triggerType" : "PUSH"
}, {
"hash" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737",
"triggerID" : "5331412a3bfb887c22641ee6bbcb7307498fb02b",
"triggerType" : "PUSH"
}, {
"hash" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 5331412a3bfb887c22641ee6bbcb7307498fb02b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15737)
* ae2e733408b7375dea2c9ee9d0e8f9acf0c82b44 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1461346981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
}, {
"hash" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c39806bc06d180eb8c07b0879bc9fad3c9cc170",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 4b4cba35e91b74dcca764894fdbcb17ad1fa197d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622)
* 8c39806bc06d180eb8c07b0879bc9fad3c9cc170 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8128:
URL: https://github.com/apache/hudi/pull/8128#issuecomment-1460409573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894861b03430217482771663639c9e413b0dca3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894861b03430217482771663639c9e413b0dca3b",
"triggerType" : "PUSH"
}, {
"hash" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15619",
"triggerID" : "40cd6e8ec745a72e56deea3f76ac80a04f5a5e47",
"triggerType" : "PUSH"
}, {
"hash" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622",
"triggerID" : "4b4cba35e91b74dcca764894fdbcb17ad1fa197d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894861b03430217482771663639c9e413b0dca3b UNKNOWN
* 4b4cba35e91b74dcca764894fdbcb17ad1fa197d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15622)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1159102731
##########
hudi-aws/src/main/java/org/apache/hudi/config/DynamoDbBasedLockConfig.java:
##########
@@ -46,7 +46,7 @@ public class DynamoDbBasedLockConfig extends HoodieConfig {
public static final ConfigProperty<String> DYNAMODB_LOCK_TABLE_NAME = ConfigProperty
.key(DYNAMODB_BASED_LOCK_PROPERTY_PREFIX + "table")
- .noDefaultValue()
+ .defaultValue("hudi_locks")
Review Comment:
The lock for the same table is identified by the `DYNAMODB_LOCK_PARTITION_KEY` config. This is the DynamoDB table to use. It can be shared across tables.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
@lokeshj1703 This is ok, though we actually don't need the differentiating logic for metadata table and it can be set to `true`, given that MDT does not have the meta fields and there is no difference in logic between setting it to `true` and `false`. I'm going to land this PR now. Let's put up a separate PR to clean it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1159299625
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
@yihua created https://github.com/apache/hudi/pull/8393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org