You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Alex Mayer (JIRA)" <my...@incubator.apache.org> on 2005/06/09 11:03:32 UTC
[jira] Created: (MYFACES-279) RegExprValidator Error-Message should show the pattern for better understanding
RegExprValidator Error-Message should show the pattern for better understanding
-------------------------------------------------------------------------------
Key: MYFACES-279
URL: http://issues.apache.org/jira/browse/MYFACES-279
Project: MyFaces
Type: Improvement
Reporter: Alex Mayer
Priority: Minor
To my mind it would be better, if the regExprValidator's ErrorMessage would show a text like this:
The submitted value ({0}) doesn't fit the pattern "{1}".
Because this gives the user and the developer a more detailed information than "the given value ({0}) is not valid". Here the user/ developer has no information what might be the correct input.
However, I changed the code of RegExprValidator and the german, english and standard message properties so that the pattern is shown in the error-message.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-279) RegExprValidator Error-Message should show the pattern for better understanding
Posted by "Matthias Weßendorf (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-279?page=all ]
Matthias Weßendorf closed MYFACES-279:
--------------------------------------
Resolution: Won't Fix
Agreed with Bruno and Kalle that technical stuff is confusing for users.
> RegExprValidator Error-Message should show the pattern for better understanding
> -------------------------------------------------------------------------------
>
> Key: MYFACES-279
> URL: http://issues.apache.org/jira/browse/MYFACES-279
> Project: MyFaces
> Type: Improvement
> Reporter: Alex Mayer
> Assignee: Matthias Weßendorf
> Priority: Minor
> Attachments: Messages.properties, Messages_de.properties, Messages_en.properties, RegExprValidator.java
>
> To my mind it would be better, if the regExprValidator's ErrorMessage would show a text like this:
> The submitted value ({0}) doesn't fit the pattern "{1}".
> Because this gives the user and the developer a more detailed information than "the given value ({0}) is not valid". Here the user/ developer has no information what might be the correct input.
> However, I changed the code of RegExprValidator and the german, english and standard message properties so that the pattern is shown in the error-message.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-279) RegExprValidator Error-Message should show the pattern for better understanding
Posted by "Alex Mayer (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-279?page=all ]
Alex Mayer updated MYFACES-279:
-------------------------------
Attachment: RegExprValidator.java
RegExprValidator message now shows the value of the pattern-attribute
> RegExprValidator Error-Message should show the pattern for better understanding
> -------------------------------------------------------------------------------
>
> Key: MYFACES-279
> URL: http://issues.apache.org/jira/browse/MYFACES-279
> Project: MyFaces
> Type: Improvement
> Reporter: Alex Mayer
> Priority: Minor
> Attachments: Messages.properties, Messages_de.properties, Messages_en.properties, RegExprValidator.java
>
> To my mind it would be better, if the regExprValidator's ErrorMessage would show a text like this:
> The submitted value ({0}) doesn't fit the pattern "{1}".
> Because this gives the user and the developer a more detailed information than "the given value ({0}) is not valid". Here the user/ developer has no information what might be the correct input.
> However, I changed the code of RegExprValidator and the german, english and standard message properties so that the pattern is shown in the error-message.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-279) RegExprValidator Error-Message should show the pattern for better understanding
Posted by "Alex Mayer (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-279?page=all ]
Alex Mayer updated MYFACES-279:
-------------------------------
Attachment: Messages.properties
Messages_de.properties
Messages_en.properties
RegExprValidator message now shows the value of the pattern-attribute
> RegExprValidator Error-Message should show the pattern for better understanding
> -------------------------------------------------------------------------------
>
> Key: MYFACES-279
> URL: http://issues.apache.org/jira/browse/MYFACES-279
> Project: MyFaces
> Type: Improvement
> Reporter: Alex Mayer
> Priority: Minor
> Attachments: Messages.properties, Messages_de.properties, Messages_en.properties, RegExprValidator.java
>
> To my mind it would be better, if the regExprValidator's ErrorMessage would show a text like this:
> The submitted value ({0}) doesn't fit the pattern "{1}".
> Because this gives the user and the developer a more detailed information than "the given value ({0}) is not valid". Here the user/ developer has no information what might be the correct input.
> However, I changed the code of RegExprValidator and the german, english and standard message properties so that the pattern is shown in the error-message.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-279) RegExprValidator Error-Message should show the pattern for better understanding
Posted by "Alex Mayer (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-279?page=comments#action_12313144 ]
Alex Mayer commented on MYFACES-279:
------------------------------------
well, since I don't have svn installed, netbeans doesn't support it, I don't know how to work with svn and how to make a svn diff (and I don't have the time to work myself into svn), and I couldn't use the myfaces-project as is in netbeans (cause of folder-structure, project.xml etc), please understand that I cannot provide the patch as svn diff.
Regards
Alex
> RegExprValidator Error-Message should show the pattern for better understanding
> -------------------------------------------------------------------------------
>
> Key: MYFACES-279
> URL: http://issues.apache.org/jira/browse/MYFACES-279
> Project: MyFaces
> Type: Improvement
> Reporter: Alex Mayer
> Priority: Minor
> Attachments: Messages.properties, Messages_de.properties, Messages_en.properties, RegExprValidator.java
>
> To my mind it would be better, if the regExprValidator's ErrorMessage would show a text like this:
> The submitted value ({0}) doesn't fit the pattern "{1}".
> Because this gives the user and the developer a more detailed information than "the given value ({0}) is not valid". Here the user/ developer has no information what might be the correct input.
> However, I changed the code of RegExprValidator and the german, english and standard message properties so that the pattern is shown in the error-message.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-279) RegExprValidator Error-Message should show the pattern for better understanding
Posted by "Bruno Aranda (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-279?page=comments#action_12313143 ]
Bruno Aranda commented on MYFACES-279:
--------------------------------------
Although it can be very helpful for developers when they debug their applications ;-) , I think that a 'technical' message can create confusion in the standard application user (depending on the targeted users, of course ;-)). It is more helpful to a user to have a comment next to the inputText that says something like "Value must follow pattern 00-XXXX" than an error message that says "The submitted value ({0}) doesn't fit the pattern \d{2}-\D{4}". You can always localize the messages for your situation. As what you need for the message to be shown is the pattern as an argument, I see well the change in the Validator, but I would keep the current myfaces messages and override them when necessary.
Please, could you create the patch using svn diff instead of copying the modified files? This will make things easier for the commiters...
Regards,
Bruno
> RegExprValidator Error-Message should show the pattern for better understanding
> -------------------------------------------------------------------------------
>
> Key: MYFACES-279
> URL: http://issues.apache.org/jira/browse/MYFACES-279
> Project: MyFaces
> Type: Improvement
> Reporter: Alex Mayer
> Priority: Minor
> Attachments: Messages.properties, Messages_de.properties, Messages_en.properties, RegExprValidator.java
>
> To my mind it would be better, if the regExprValidator's ErrorMessage would show a text like this:
> The submitted value ({0}) doesn't fit the pattern "{1}".
> Because this gives the user and the developer a more detailed information than "the given value ({0}) is not valid". Here the user/ developer has no information what might be the correct input.
> However, I changed the code of RegExprValidator and the german, english and standard message properties so that the pattern is shown in the error-message.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-279) RegExprValidator Error-Message should show the pattern for better understanding
Posted by "Kalle Korhonen (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-279?page=comments#action_12313171 ]
Kalle Korhonen commented on MYFACES-279:
----------------------------------------
I sort of agree with Bruno that the technical message might confuse users, but in many cases it might also make sense to display it. If we don't have it as a resource parameter, then there's no easy way to allow it to be shown. Shouldn't we rather think about it the other way around - if you consider it to be confusing for your users, you would customize the message not to show the actual pattern?
Or (and this might be off-topic, but), is there some other, easy way to to show a completely application/field dependent message, like
<h:message for ="inputField>
<h:outputText>Only !@#$% values allowed</h:outputText>
</h:message>
Something like that would make sense to me.
> RegExprValidator Error-Message should show the pattern for better understanding
> -------------------------------------------------------------------------------
>
> Key: MYFACES-279
> URL: http://issues.apache.org/jira/browse/MYFACES-279
> Project: MyFaces
> Type: Improvement
> Reporter: Alex Mayer
> Assignee: Matthias Weßendorf
> Priority: Minor
> Attachments: Messages.properties, Messages_de.properties, Messages_en.properties, RegExprValidator.java
>
> To my mind it would be better, if the regExprValidator's ErrorMessage would show a text like this:
> The submitted value ({0}) doesn't fit the pattern "{1}".
> Because this gives the user and the developer a more detailed information than "the given value ({0}) is not valid". Here the user/ developer has no information what might be the correct input.
> However, I changed the code of RegExprValidator and the german, english and standard message properties so that the pattern is shown in the error-message.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira