[jira] [Issue Comment Edited] (TS-826) TSHttpTxnErrorBodySet() can leak memory

["Brian Geffon (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164734#comment-13164734 ] 

Brian Geffon edited comment on TS-826 at 12/7/11 9:42 PM:
----------------------------------------------------------

Correct me if I'm wrong but with this patch it's still leaking mimetype. See HttpSM::setup_internal_transfer line 5416 which frees internal_msg_buffer_type...it's expected that mimetype was malloced since clearly it's being freed. So that means there is still a memory leak in TSHttpTxnErrorBodySet().
                
      was (Author: briang):
    Correct me if I'm wrong but with this patch it's still leaking mimetype...
                  
> TSHttpTxnErrorBodySet() can leak memory
> ---------------------------------------
>
>                 Key: TS-826
>                 URL: https://issues.apache.org/jira/browse/TS-826
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>    Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
>            Reporter: William Bardwell
>            Assignee: Leif Hedstrom
>            Priority: Minor
>             Fix For: 3.1.0, 3.0.1
>
>         Attachments: ebs.diff
>
>
> TSHttpTxnErrorBodySet() sets HttpSM::t_state.internal_msg_buffer without freeing any old contents in there.
> There can be an error message in that if you have a request with a bad hostname and you let the transaction get past DNS
> lookup.  Instead it should free the contents, or there should be another field that it sets and nothing else does.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira