You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by dmvolod <gi...@git.apache.org> on 2017/06/23 15:02:01 UTC
[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...
GitHub user dmvolod opened a pull request:
https://github.com/apache/thrift/pull/1294
THRIFT-4233 Make THsHaServer.invoker available (get method only) in inherited classes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmvolod/thrift THRIFT-4233
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1294
----
commit 3d97c860c2c8aa7e6c5013edc1456cf8706ae654
Author: Dmitry Volodin <dm...@gmail.com>
Date: 2017-06-23T14:57:40Z
THRIFT-4233 Make THsHaServer.invoker available (get method only) in
inherited classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1294#discussion_r140344024
--- Diff: lib/java/src/org/apache/thrift/server/THsHaServer.java ---
@@ -154,7 +154,10 @@ protected static ExecutorService createInvokerPool(Args options) {
return invoker;
}
-
+
+ protected ExecutorService getInvoker() {
--- End diff --
This could probably be static, given the method above is also static? Thoughts?
---
[GitHub] thrift issue #1294: THRIFT-4233 Make THsHaServer.invoker available (get meth...
Posted by dmvolod <gi...@git.apache.org>.
Github user dmvolod commented on the issue:
https://github.com/apache/thrift/pull/1294
Is there any chance to review this changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...
Posted by dmvolod <gi...@git.apache.org>.
Github user dmvolod commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1294#discussion_r140350410
--- Diff: lib/java/src/org/apache/thrift/server/THsHaServer.java ---
@@ -154,7 +154,10 @@ protected static ExecutorService createInvokerPool(Args options) {
return invoker;
}
-
+
+ protected ExecutorService getInvoker() {
--- End diff --
Yes, you are right. I will close this PR, as I'm unable to add commit to this PR (remove remote repo) and create a new one.
Thank you.
---
[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...
Posted by dmvolod <gi...@git.apache.org>.
Github user dmvolod closed the pull request at:
https://github.com/apache/thrift/pull/1294
---