You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/01/25 21:18:46 UTC
Review Request 65344: Updated the docs for agent ping timeout flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65344/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Vinod Kone.
Repository: mesos
Description
-------
Updated docs for agent ping timeout flags.
Diffs
-----
docs/configuration/master.md e3cfb24443bfcff27606efcae46e70bd2614955e
src/master/flags.cpp b49cb63bfebb286ae4f5e665652dc5f8f2964ceb
Diff: https://reviews.apache.org/r/65344/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 65344: Updated the docs for agent ping timeout
flags.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65344/#review196534
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 25, 2018, 9:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65344/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 9:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docs for agent ping timeout flags.
>
>
> Diffs
> -----
>
> docs/configuration/master.md e3cfb24443bfcff27606efcae46e70bd2614955e
> src/master/flags.cpp b49cb63bfebb286ae4f5e665652dc5f8f2964ceb
>
>
> Diff: https://reviews.apache.org/r/65344/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65344: Updated the docs for agent ping timeout
flags.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65344/#review196295
-----------------------------------------------------------
PASS: Mesos patch 65344 was successfully built and tested.
Reviews applied: `['65344']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65344
- Mesos Reviewbot Windows
On Jan. 25, 2018, 1:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65344/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 1:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docs for agent ping timeout flags.
>
>
> Diffs
> -----
>
> docs/configuration/master.md e3cfb24443bfcff27606efcae46e70bd2614955e
> src/master/flags.cpp b49cb63bfebb286ae4f5e665652dc5f8f2964ceb
>
>
> Diff: https://reviews.apache.org/r/65344/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65344: Updated the docs for agent ping timeout
flags.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65344/#review196313
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Reviews applied: `['65344']`
Failed command: `D:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65344
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65344/logs/libprocess-tests-stdout.log):
```
[ OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (407 ms)
[ RUN ] Scheme/HTTPTest.WWWAuthenticateHeader/1
[ OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (22 ms)
[ RUN ] Scheme/HTTPTest.Accepts/0
[ OK ] Scheme/HTTPTest.Accepts/0 (181 ms)
[ RUN ] Scheme/HTTPTest.Accepts/1
[ OK ] Scheme/HTTPTest.Accepts/1 (29 ms)
[----------] 36 tests from Scheme/HTTPTest (6099 ms total)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest
[ RUN ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
[ OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (331 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
[ OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (361 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (922 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1310 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (2928 ms total)
[----------] Global test environment tear-down
[==========] 225 tests from 35 test cases ran. (30383 ms total)
[ PASSED ] 224 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] SSLTest.ProtocolMismatch
1 FAILED TEST
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65344/logs/libprocess-tests-stderr.log):
```
I0126 10:31:18.117390 5936 process.cpp:928] Stopped the socket accept loop
I0126 10:31:18.147389 6156 process.cpp:928] Stopped the socket accept loop
I0126 10:31:18.477361 5936 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0126 10:31:18.477361 5936 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0126 10:31:18.477361 5936 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\NGThno\cert.pem
I0126 10:31:18.477361 5936 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\NGThno
I0126 10:31:18.839330 5936 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0126 10:31:18.840332 5936 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I0126 10:31:18.840332 5936 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0126 10:31:18.840332 5936 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\gW2qgS\cert.pem
I0126 10:31:18.840332 5936 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\gW2qgS
I0126 10:31:19.094310 5936 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I0126 10:31:19.094310 5936 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0126 10:31:19.094310 5936 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0126 10:31:19.094310 5936 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\MZodAZ\cert.pem
I0126 10:31:20.382262 5936 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I0126 10:31:20.382262 5936 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0126 10:31:20.382262 5936 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I0126 10:31:20.382262 5936 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0126 10:31:20.382262 5936 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\wqNibD\cert.pem
I0126 10:31:21.107635 5572 process.cpp:928] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 25, 2018, 9:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65344/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 9:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docs for agent ping timeout flags.
>
>
> Diffs
> -----
>
> docs/configuration/master.md e3cfb24443bfcff27606efcae46e70bd2614955e
> src/master/flags.cpp b49cb63bfebb286ae4f5e665652dc5f8f2964ceb
>
>
> Diff: https://reviews.apache.org/r/65344/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65344: Updated the docs for agent ping timeout
flags.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65344/#review196292
-----------------------------------------------------------
PASS: Mesos patch 65344 was successfully built and tested.
Reviews applied: `['65344']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65344
- Mesos Reviewbot Windows
On Jan. 25, 2018, 4:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65344/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 4:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docs for agent ping timeout flags.
>
>
> Diffs
> -----
>
> docs/configuration/master.md e3cfb24443bfcff27606efcae46e70bd2614955e
> src/master/flags.cpp b49cb63bfebb286ae4f5e665652dc5f8f2964ceb
>
>
> Diff: https://reviews.apache.org/r/65344/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>