You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Jim Jagielski <ji...@jaguNET.com> on 2007/09/15 19:04:44 UTC
Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.
Costin Manolache wrote:
>
> Well, regarding the veto - it's simple. I second Remy's opinion that the
> veto is valid
> and the change is not right at the moment, and I guess that should close
> this discussion.
>
> The discussion about whether to add such a feature or not - I think a simple
> vote
> would solve this as well, it's quite a subjective and taste-based issue.
> There are many
> other features that serve a small number of users only, the usual question
> was
> if enough tomcat developers are willing to support and want the feature.
>
Just to be clear; Is the veto against the actual patch or the feature?
If for the actual patch, then maybe you and Remy could provide feedback
to Tim on what would make it acceptable... If for the actual feature,
then I'm not sure how to jive that with your 2nd statement about a simple
vote...
Thanks!
--
===========================================================================
Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/
"If you can dodge a wrench, you can dodge a ball."
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java
webapps/docs/changelog.
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Costin Manolache wrote:
>
> Regarding feedback on patch - I think I expressed my concerns:
> - more analysis and understanding of security implications
> - if possible to do it at a different (higher) level
> - if it can be done in a modular fashion, i.e. keeping the default impl the
> way it is,
> without this feature, and adding a way to configure a different module with
> this or
> other features. ( bonus points if the add-on module is a separate release
> and very easy
> to add )
>
> In other words - bloat ( same as Remy's concern I guess) and understanding
> if this is the
> best possible implementation if the bloat is deemed acceptable.
You know the seperate modules, with CGI and SSI moved out and into that,
would be a really terrific thing. Where all of these 'non-servlet/non-jsp'
features are unwanted, it would be good to lighten the bloat. Props to the
idea and anyone who decides to tackle it :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java
webapps/docs/changelog.
Posted by Tim Funk <fu...@joedog.org>.
As everyone will see ... I reverted. Its not the end of the world if
this gets in since I can easily maintain a private version with alias
support for myself. I thought it was a helpful bloatage for others. It
might be worthwhile keeping the discussion active for the moment if
anyone else has opinions.
-Tim
Costin Manolache wrote:
> My understanding was that veto can only be against a patch.
>
> And for a feature - some majority would do it.
>
> Regarding feedback on patch - I think I expressed my concerns:
> - more analysis and understanding of security implications
> - if possible to do it at a different (higher) level
> - if it can be done in a modular fashion, i.e. keeping the default impl the
> way it is,
> without this feature, and adding a way to configure a different module with
> this or
> other features. ( bonus points if the add-on module is a separate release
> and very easy
> to add )
>
> In other words - bloat ( same as Remy's concern I guess) and understanding
> if this is the
> best possible implementation if the bloat is deemed acceptable.
>
> Costin
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.
Posted by Costin Manolache <co...@gmail.com>.
On 9/15/07, Jim Jagielski <ji...@jagunet.com> wrote:
>
> Costin Manolache wrote:
> >
> > Well, regarding the veto - it's simple. I second Remy's opinion that the
> > veto is valid
> > and the change is not right at the moment, and I guess that should
> close
> > this discussion.
> >
> > The discussion about whether to add such a feature or not - I think a
> simple
> > vote
> > would solve this as well, it's quite a subjective and taste-based issue.
> > There are many
> > other features that serve a small number of users only, the usual
> question
> > was
> > if enough tomcat developers are willing to support and want the feature.
> >
>
> Just to be clear; Is the veto against the actual patch or the feature?
> If for the actual patch, then maybe you and Remy could provide feedback
> to Tim on what would make it acceptable... If for the actual feature,
> then I'm not sure how to jive that with your 2nd statement about a simple
> vote...
My understanding was that veto can only be against a patch.
And for a feature - some majority would do it.
Regarding feedback on patch - I think I expressed my concerns:
- more analysis and understanding of security implications
- if possible to do it at a different (higher) level
- if it can be done in a modular fashion, i.e. keeping the default impl the
way it is,
without this feature, and adding a way to configure a different module with
this or
other features. ( bonus points if the add-on module is a separate release
and very easy
to add )
In other words - bloat ( same as Remy's concern I guess) and understanding
if this is the
best possible implementation if the bloat is deemed acceptable.
Costin