[GitHub] matthiasblaesing commented on issue #940: Netbeans 1074 web.struts donation review

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #940: Netbeans 1074 web.struts donation review
URL: https://github.com/apache/incubator-netbeans/pull/940#issuecomment-427665926
 
 
   Gathering the resource files from different jars is a sound approach. For the struts libraries, these all contain a NOTICE file. Please add it as `<basename>-notice.txt`.
   
   The gathered DTDs and Schemas come from the Struts project and require additons to the NOTICE file. A possible approach is visible in `ide/xml.wsdl.model`. There a secondary jar is created and added to the classpath. One problem here might be, that you'll get a split package (parts of `org.netbeans.modules.web.struts.resources` will be in the modules jar and parts in the secondary jar).
   
   The `struts.xml` file is important and must be included (please clear with oracle if you are allowed to include it under the ALv2-ASF license). The file contains the library definition, that is used by netbeans java project. The file is also referenced by the layer.xml (see line 121-127). The same goes for the struts-config_1_2.mdd file.
   
   The build currently fails for me (the filesets in build.xml lines 54-57 are not correct).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists