You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/13 08:57:06 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #3532: stm32g4xx: add support for PWM
raiden00pl opened a new pull request #3532:
URL: https://github.com/apache/incubator-nuttx/pull/3532
## Summary
stm32/Kconfig: G4 chips use TIMERS_V2
stm32g4xx: add support for PWM
## Impact
## Testing
pwm example on nucleo-g431rb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on pull request #3532: stm32g4xx: add support for PWM
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on pull request #3532:
URL: https://github.com/apache/incubator-nuttx/pull/3532#issuecomment-819250605
Yes, there are some differences in registers, but the basic functionality of the TIMER is the same. Differences mainly concern the functions that will not be used in the general PWM driver and are dedicated to more sophisticated applications. I think we can extend the current TIMER header without a separate file. I'll take care of it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on pull request #3532: stm32g4xx: add support for PWM
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on pull request #3532:
URL: https://github.com/apache/incubator-nuttx/pull/3532#issuecomment-819286182
After some work on this I see that separating the definition to a new file will be better. Merge this to existing TIMERS_V2 causes too much mess and complexity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #3532: stm32g4xx: add support for PWM
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #3532:
URL: https://github.com/apache/incubator-nuttx/pull/3532#issuecomment-819034982
I think the G4 chips use a different version of Timers IP than TIMERS_V2. The register definitions are very similar to TIMERS_V2 but I think there are some discrepancies, including added registers (more features) and also (I think) some changed registers and bitfields, so your implementation might not work right if code tries to use certain bitfields.
Some time ago I began work to add the register definitions for STM32G4 and I think it's substantially complete, but I didn't open a PR at the time because I first wanted to see if my changes should be merged into the existing TIMERS_V2 header, or be left as a separate file.
It can be found in the stm32-tim-improve branch of my fork:
https://github.com/hartmannathan/incubator-nuttx/commit/d5db24c029ef25c732f0240cd2c74a1de5685b7a
I can't work on it right now but feel free to use pieces of it, or let me know if you think it's acceptable as-is (as a separate file) and I'll open a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3532: stm32g4xx: add support for PWM
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3532:
URL: https://github.com/apache/incubator-nuttx/pull/3532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3532: stm32g4xx: add support for PWM
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3532:
URL: https://github.com/apache/incubator-nuttx/pull/3532#issuecomment-819434722
see https://github.com/apache/incubator-nuttx/pull/3544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org