[jira] [Commented] (BOOKKEEPER-933) ClientConfiguration always inherits System properties

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337484#comment-15337484 ] 

Sijie Guo commented on BOOKKEEPER-933:
--------------------------------------

+1 for this change. we should remove SystemProperties from both ClientConfiguration and ServerConfiguration

> ClientConfiguration always inherits System properties
> -----------------------------------------------------
>
>                 Key: BOOKKEEPER-933
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-933
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>            Reporter: Enrico Olivelli
>             Fix For: 4.5.0
>
>
> ClientConfiguration is always adding System.getProperties()
> {code}
>  protected AbstractConfiguration() {
>         super();
>         // add configuration for system properties
>         addConfiguration(new SystemConfiguration());
>     }
> {code}
> This is useful is some cases but sometimes it is very harmful because the user could modify the client behaviour inadvertently, for instance:: throttle, readTimeout....



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)