[jira] [Commented] (STORM-922) Storm-Core Dependencies Renamed in Shade JAR

["Rick Kellogg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951995#comment-14951995 ] 

Rick Kellogg commented on STORM-922:
------------------------------------

Please document how this was resolved.  I believe we are shading the dependencies now (which is desirable).  As such the original request could not have been fulfilled or at least requires additional documentation.

> Storm-Core Dependencies Renamed in Shade JAR
> --------------------------------------------
>
>                 Key: STORM-922
>                 URL: https://issues.apache.org/jira/browse/STORM-922
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 0.11.0
>            Reporter: Brian Ghigiarelli
>            Assignee: Robert Joseph Evans
>             Fix For: 0.10.0, 0.11.0
>
>
> storm-core's pom.xml file has dependencies on a variety of widely used open source libraries such as commons-io, commons-collections, guava, etc.
> Any user-defined topologies that depend on the storm-core JAR then assume to have those libraries available during runtime through transitive dependencies.
> However, the Shade JAR built by storm-core renames all of the package names of those libraries to move them under org.apache.storm.*.
> This causes runtime NoClassDefFoundError's from for topologies that were previously succeeding (e.g., org.apache.commons.io.FileUtils).
> Recommend providing those libraries since the Maven dependencies declare that they are including them.  If the goal is to provide classpath isolation for Storm vs. topologies, the original dependencies should still be provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)