You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2015/12/08 21:07:15 UTC
[2/2] mesos git commit: Fixed punctuation usage in some error
messages.
Fixed punctuation usage in some error messages.
Error messages should generally not end in punctuation.
Review: https://reviews.apache.org/r/41098
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/04c3d6e6
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/04c3d6e6
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/04c3d6e6
Branch: refs/heads/master
Commit: 04c3d6e66e5310f86f687fc64a6ed45c793d9778
Parents: d00e8bc
Author: Neil Conway <ne...@gmail.com>
Authored: Tue Dec 8 12:06:58 2015 -0800
Committer: Jie Yu <yu...@gmail.com>
Committed: Tue Dec 8 12:06:59 2015 -0800
----------------------------------------------------------------------
src/master/http.cpp | 4 ++--
src/master/validation.cpp | 4 ++--
src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/04c3d6e6/src/master/http.cpp
----------------------------------------------------------------------
diff --git a/src/master/http.cpp b/src/master/http.cpp
index 9097eda..5d33138 100644
--- a/src/master/http.cpp
+++ b/src/master/http.cpp
@@ -833,7 +833,7 @@ Try<string> getFormValue(
Option<string> value = values.get(key);
if (value.isNone()) {
- return Error("Missing value for '" + key + "'.");
+ return Error("Missing value for '" + key + "'");
}
// HTTP decode the value.
@@ -844,7 +844,7 @@ Try<string> getFormValue(
// Treat empty string as an error.
if (decodedValue.isSome() && decodedValue.get().empty()) {
- return Error("Empty string for '" + key + "'.");
+ return Error("Empty string for '" + key + "'");
}
return decodedValue.get();
http://git-wip-us.apache.org/repos/asf/mesos/blob/04c3d6e6/src/master/validation.cpp
----------------------------------------------------------------------
diff --git a/src/master/validation.cpp b/src/master/validation.cpp
index 6a0296b..6a43bce 100644
--- a/src/master/validation.cpp
+++ b/src/master/validation.cpp
@@ -678,7 +678,7 @@ Option<Error> validate(
}
if (principal.isNone()) {
- return Error("Cannot reserve resources without a principal.");
+ return Error("Cannot reserve resources without a principal");
}
foreach (const Resource& resource, reserve.resources()) {
@@ -725,7 +725,7 @@ Option<Error> validate(
}
if (!hasPrincipal) {
- return Error("Resources cannot be unreserved without a principal.");
+ return Error("Resources cannot be unreserved without a principal");
}
// NOTE: We don't check that 'FrameworkInfo.principal' matches
http://git-wip-us.apache.org/repos/asf/mesos/blob/04c3d6e6/src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp b/src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp
index b7ba00b..4d82c2b 100644
--- a/src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp
+++ b/src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp
@@ -82,7 +82,7 @@ Try<Isolator*> CgroupsPerfEventIsolatorProcess::create(const Flags& flags)
}
if (!flags.perf_events.isSome()) {
- return Error("No perf events specified.");
+ return Error("No perf events specified");
}
set<string> events;