You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/01 15:58:34 UTC

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1270: MINIFICPP-1734 Add integration test for Kubernetes log collection

fgerlits commented on a change in pull request #1270:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1270#discussion_r816907645



##########
File path: docker/test/integration/features/kubernetes.feature
##########
@@ -0,0 +1,43 @@
+Feature: TailFile can collect logs from Kubernetes pods

Review comment:
       I'm not sure.  I have added a license header to new files containing code, but not to new files containing test data.  I think these feature files are test data.
   
   Do you think we need to add a header to all files, or just that feature files are code and not test data, so should have a header?  There is no technical problem with adding headers to feature files; lines starting with # are ignored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org