You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "arsenalzp (via GitHub)" <gi...@apache.org> on 2025/05/29 18:07:05 UTC

[PR] Implement single thread for bulk operations [accumulo]

arsenalzp opened a new pull request, #5592:
URL: https://github.com/apache/accumulo/pull/5592

   This PR introduces single thread for bulk operations. PR is related to issue #5524 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2164536313


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -351,15 +347,6 @@ public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String pool
       }
       return null;
     })));
-    workerPool.shutdown();
-    try {
-      while (!workerPool.awaitTermination(1000L, TimeUnit.MILLISECONDS)) {}
-      for (Future<Void> future : results) {
-        future.get();
-      }

Review Comment:
   > Are you sure it is necessary to block bulkRename method?
   
   Yes, callers of the method expect the renames to be complete when the method returns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#issuecomment-2971815925

   Hello,
   I run `mvn clean package` however it failed with warnings and subsequent error:
   
   ```
   [WARNING] COMPILATION WARNING : 
   [INFO] -------------------------------------------------------------
   [WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java:[80,81] possible 'this' escape before subclass is fully initialized
   [WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:[49,35] non-transient instance field of a serializable class declared with a non-serializable type
   [WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:[50,30] non-transient instance field of a serializable class declared with a non-serializable type
   [WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooSession.java:[251,30] implicit cast from long to int in compound assignment is possibly lossy
   [WARNING] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/logging/ConditionalLogger.java:[69,9] non-transient instance field of a serializable class declared with a non-serializable type
   [INFO] 5 warnings 
   ```
   ...
   ```
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project accumulo-core: Compilation failure
   [ERROR] /home/arsenal/eclipse-workspace/accumulo/core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java: warnings found and -Werror specified
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#issuecomment-2984265651

   Hello colleagues,
   What is remaining before merge intro main?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2116875090


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/BulkImportMove.java:
##########
@@ -99,6 +101,8 @@ private void moveFiles(FateId fateId, Path sourceDir, Path bulkDir, Manager mana
         "/" + bulkDir.getParent().getName() + "/" + bulkDir.getName(), fateId);
     AccumuloConfiguration aConf = manager.getConfiguration();
     int workerCount = aConf.getCount(Property.MANAGER_RENAME_THREADS);
+    ExecutorService workerPool = ThreadPools.getServerThreadPools()

Review Comment:
   This still creates a thread pool per operation.  Need a single thread pool for the manager process.  This thread pool should be moved to the [Manager](https://github.com/apache/accumulo/blob/main/server/manager/src/main/java/org/apache/accumulo/manager/Manager.java).  Could add an instance variable to the manager class for the executor service, create the thread pool in the manager constructor, and add a a method to get the thread pool. With that done can do something like the following here.
   
   ```java
   fs.bulkRename(oldToNewMap, manager.getRenameExecutor(), fateId);
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2138573037


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -351,7 +348,6 @@ public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String pool
       }
       return null;
     })));
-    workerPool.shutdown();
     try {
       while (!workerPool.awaitTermination(1000L, TimeUnit.MILLISECONDS)) {}

Review Comment:
   This loop to await termination of the pool needs to be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2136333503


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/BulkImportMove.java:
##########
@@ -97,8 +94,7 @@ private void moveFiles(FateId fateId, Path sourceDir, Path bulkDir, Manager mana
       final VolumeManager fs, Map<String,String> renames) throws Exception {
     manager.getContext().getAmple().addBulkLoadInProgressFlag(
         "/" + bulkDir.getParent().getName() + "/" + bulkDir.getName(), fateId);
-    AccumuloConfiguration aConf = manager.getConfiguration();
-    int workerCount = aConf.getCount(Property.MANAGER_RENAME_THREADS);
+    ExecutorService workerPool = manager.getWorkerPool();

Review Comment:
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2130390727


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -323,11 +322,9 @@ public boolean rename(Path path, Path newPath) throws IOException {
   }
 
   @Override
-  public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String poolName,
-      FateId fateId) throws IOException {
+  public void bulkRename(Map<Path,Path> oldToNewPathMap, ExecutorService workerPool, FateId fateId)

Review Comment:
   This method shuts down the thread pool and waits for its termination later.   Now that the thread pool is passed in, that code should be removed.



##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/BulkImportMove.java:
##########
@@ -97,8 +94,7 @@ private void moveFiles(FateId fateId, Path sourceDir, Path bulkDir, Manager mana
       final VolumeManager fs, Map<String,String> renames) throws Exception {
     manager.getContext().getAmple().addBulkLoadInProgressFlag(
         "/" + bulkDir.getParent().getName() + "/" + bulkDir.getName(), fateId);
-    AccumuloConfiguration aConf = manager.getConfiguration();
-    int workerCount = aConf.getCount(Property.MANAGER_RENAME_THREADS);
+    ExecutorService workerPool = manager.getWorkerPool();

Review Comment:
   Could this variable be inlined?



##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/MoveExportedFiles.java:
##########
@@ -59,8 +57,8 @@ class MoveExportedFiles extends ManagerRepo {
 
   @Override
   public Repo<Manager> call(FateId fateId, Manager manager) throws Exception {
-    int workerCount = manager.getConfiguration().getCount(Property.MANAGER_RENAME_THREADS);
     VolumeManager fs = manager.getVolumeManager();
+    ExecutorService workerPool = manager.getWorkerPool();

Review Comment:
   Could this variable be inlined?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #5592:
URL: https://github.com/apache/accumulo/pull/5592


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2187221660


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -211,6 +212,7 @@ public class Manager extends AbstractServer implements LiveTServerSet.Listener {
   private final TabletStateStore rootTabletStore;
   private final TabletStateStore metadataTabletStore;
   private final TabletStateStore userTabletStore;
+  private final ExecutorService workerPool;

Review Comment:
   I understand. Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2136328860


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -323,11 +322,9 @@ public boolean rename(Path path, Path newPath) throws IOException {
   }
 
   @Override
-  public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String poolName,
-      FateId fateId) throws IOException {
+  public void bulkRename(Map<Path,Path> oldToNewPathMap, ExecutorService workerPool, FateId fateId)

Review Comment:
   Ah, I really overlooked that line of code!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2183278160


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -211,6 +212,7 @@ public class Manager extends AbstractServer implements LiveTServerSet.Listener {
   private final TabletStateStore rootTabletStore;
   private final TabletStateStore metadataTabletStore;
   private final TabletStateStore userTabletStore;
+  private final ExecutorService workerPool;

Review Comment:
   We would not want to use this thread pool for other purporse because it is created using the user facing property Property.MANAGER_RENAME_THREADS that gives it a very specific purpose.  As long as the thread pool is tightly coupled to this user property it should only be used for that purpose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#issuecomment-3058922670

   Thanks for the contribution @arsenalzp.  If you would like to be added as a contributor please make a PR to this page https://github.com/apache/accumulo-website/blob/main/pages/people.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2136336038


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/MoveExportedFiles.java:
##########
@@ -59,8 +57,8 @@ class MoveExportedFiles extends ManagerRepo {
 
   @Override
   public Repo<Manager> call(FateId fateId, Manager manager) throws Exception {
-    int workerCount = manager.getConfiguration().getCount(Property.MANAGER_RENAME_THREADS);
     VolumeManager fs = manager.getVolumeManager();
+    ExecutorService workerPool = manager.getWorkerPool();

Review Comment:
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2117673952


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/BulkImportMove.java:
##########
@@ -99,6 +101,8 @@ private void moveFiles(FateId fateId, Path sourceDir, Path bulkDir, Manager mana
         "/" + bulkDir.getParent().getName() + "/" + bulkDir.getName(), fateId);
     AccumuloConfiguration aConf = manager.getConfiguration();
     int workerCount = aConf.getCount(Property.MANAGER_RENAME_THREADS);
+    ExecutorService workerPool = ThreadPools.getServerThreadPools()

Review Comment:
   Hello,
   I agree. 
   I proposed singleton on the Manager level in the [issue](https://github.com/apache/accumulo/issues/5524#issuecomment-2920040513) discussion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2162538212


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -351,15 +347,6 @@ public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String pool
       }
       return null;
     })));
-    workerPool.shutdown();
-    try {
-      while (!workerPool.awaitTermination(1000L, TimeUnit.MILLISECONDS)) {}
-      for (Future<Void> future : results) {
-        future.get();
-      }

Review Comment:
   I reverted handling of `Future` objects as you wanted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2164861760


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -351,15 +347,6 @@ public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String pool
       }
       return null;
     })));
-    workerPool.shutdown();
-    try {
-      while (!workerPool.awaitTermination(1000L, TimeUnit.MILLISECONDS)) {}
-      for (Future<Void> future : results) {
-        future.get();
-      }

Review Comment:
   Thank you for explanation! I made changes as you expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2155392409


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -351,15 +347,6 @@ public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String pool
       }
       return null;
     })));
-    workerPool.shutdown();
-    try {
-      while (!workerPool.awaitTermination(1000L, TimeUnit.MILLISECONDS)) {}
-      for (Future<Void> future : results) {
-        future.get();
-      }

Review Comment:
   Want to keep this code that waits on the futures.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#issuecomment-3015205798

   Conflict was resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2162499551


##########
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java:
##########
@@ -351,15 +347,6 @@ public void bulkRename(Map<Path,Path> oldToNewPathMap, int poolSize, String pool
       }
       return null;
     })));
-    workerPool.shutdown();
-    try {
-      while (!workerPool.awaitTermination(1000L, TimeUnit.MILLISECONDS)) {}
-      for (Future<Void> future : results) {
-        future.get();
-      }

Review Comment:
   Are you sure it is necessary to block `bulkRename` method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "arsenalzp (via GitHub)" <gi...@apache.org>.
arsenalzp commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2178419520


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -211,6 +212,7 @@ public class Manager extends AbstractServer implements LiveTServerSet.Listener {
   private final TabletStateStore rootTabletStore;
   private final TabletStateStore metadataTabletStore;
   private final TabletStateStore userTabletStore;
+  private final ExecutorService workerPool;

Review Comment:
   Class `ExecutorService` is using for rename operation presently, however in the future it would be used for other operation, so I don't think field name should be tied to  operation name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Implement single thread for bulk operations [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2175327308


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -211,6 +212,7 @@ public class Manager extends AbstractServer implements LiveTServerSet.Listener {
   private final TabletStateStore rootTabletStore;
   private final TabletStateStore metadataTabletStore;
   private final TabletStateStore userTabletStore;
+  private final ExecutorService workerPool;

Review Comment:
   A more specific name for this pool would make it easier to know the purpose of this pool.  Could name it `renamePool` of something like that instead of `workerPool`.



##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1557,4 +1562,13 @@ private Map<FateInstanceType,Fate<Manager>> getFateRefs() {
   public ServiceLock getLock() {
     return managerLock;
   }
+
+  /**
+   * Get Threads Pool instance which is used by blocked I/O
+   *
+   * @return {@link ExecutorService}
+   */
+  public ExecutorService getWorkerPool() {

Review Comment:
   If the variable name is changed would be good to rename this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org