You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/02 16:45:24 UTC

[GitHub] [arrow] ianmcook commented on a change in pull request #11833: ARROW-14961: [C++] Bump google benchmark version

ianmcook commented on a change in pull request #11833:
URL: https://github.com/apache/arrow/pull/11833#discussion_r761279230



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -463,7 +463,6 @@ if(DEFINED ENV{ARROW_GBENCHMARK_URL})
 else()
   set_urls(GBENCHMARK_SOURCE_URL
            "https://github.com/google/benchmark/archive/${ARROW_GBENCHMARK_BUILD_VERSION}.tar.gz"
-           "https://github.com/ursa-labs/thirdparty/releases/download/latest/gbenchmark-${ARROW_GBENCHMARK_BUILD_VERSION}.tar.gz"

Review comment:
        I added https://github.com/ursa-labs/thirdparty/releases/download/latest/gbenchmark-v1.6.0.tar.gz to our thirdparty tarballs at https://github.com/ursa-labs/thirdparty/releases/tag/latest. Could you please retain this line? Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org