You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "csun5285 (via GitHub)" <gi...@apache.org> on 2026/01/15 10:04:07 UTC
[PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
csun5285 opened a new pull request, #59927:
URL: https://github.com/apache/doris/pull/59927
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3758391549
please add performance improvements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3754377325
<details>
<summary>ClickBench: <b>Total hot run time: 26.6 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5b88993447922e7aafa54a610eeb42f6138b2542, data reload: false
query1 0.05 0.05 0.05
query2 0.10 0.05 0.05
query3 0.25 0.08 0.08
query4 1.61 0.12 0.10
query5 0.27 0.25 0.26
query6 1.16 0.67 0.66
query7 0.03 0.02 0.03
query8 0.06 0.04 0.04
query9 0.57 0.51 0.50
query10 0.54 0.55 0.54
query11 0.15 0.09 0.10
query12 0.15 0.11 0.11
query13 0.60 0.58 0.59
query14 0.96 0.97 0.95
query15 0.79 0.79 0.77
query16 0.40 0.39 0.42
query17 1.07 1.04 0.99
query18 0.23 0.21 0.21
query19 1.83 1.90 1.77
query20 0.02 0.01 0.01
query21 15.44 0.24 0.13
query22 5.30 0.05 0.05
query23 16.03 0.28 0.10
query24 1.68 0.23 0.48
query25 0.11 0.08 0.05
query26 0.15 0.14 0.13
query27 0.05 0.04 0.05
query28 3.95 1.08 0.89
query29 12.56 3.91 3.14
query30 0.27 0.13 0.12
query31 2.80 0.64 0.39
query32 3.24 0.55 0.47
query33 3.03 3.02 2.99
query34 16.13 5.04 4.42
query35 4.48 4.45 4.43
query36 0.65 0.50 0.49
query37 0.10 0.07 0.07
query38 0.08 0.05 0.03
query39 0.05 0.03 0.03
query40 0.17 0.15 0.14
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 97.27 s
Total hot run time: 26.6 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3754034520
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3757981781
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (24/24)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59927_5b88993447922e7aafa54a610eeb42f6138b2542_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59927_5b88993447922e7aafa54a610eeb42f6138b2542_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.13% (25332/35122) |
| Line Coverage | 58.88% (265070/450198) |
| Region Coverage | 53.74% (220299/409905) |
| Branch Coverage | 55.32% (94455/170749) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3759386579
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on code in PR #59927:
URL: https://github.com/apache/doris/pull/59927#discussion_r2707419901
##########
be/src/util/rle_encoding.h:
##########
@@ -435,17 +435,35 @@ template <typename T>
void RleEncoder<T>::Put(T value, size_t run_length) {
DCHECK(bit_width_ == 64 || value < (1LL << bit_width_));
- // TODO(perf): remove the loop and use the repeat_count_
- for (; run_length > 0; run_length--) {
+ // Fast path: if this is a continuation of the current repeated run and
Review Comment:
这里 num_buffered_values_ 为0，或者不为0都是有可能的，如果之前的 buffer 被flush 了就是0，否则就不是0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #59927:
URL: https://github.com/apache/doris/pull/59927#discussion_r2707194542
##########
be/src/util/rle_encoding.h:
##########
@@ -435,17 +435,35 @@ template <typename T>
void RleEncoder<T>::Put(T value, size_t run_length) {
DCHECK(bit_width_ == 64 || value < (1LL << bit_width_));
- // TODO(perf): remove the loop and use the repeat_count_
- for (; run_length > 0; run_length--) {
+ // Fast path: if this is a continuation of the current repeated run and
Review Comment:
Need to DCHECK num_buffered_values_==0 or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3753907875
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3759777178
<details>
<summary>TPC-DS: <b>Total hot run time: 174384 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e3144674fc43c4e04727f9c1001f1d4b71765244, data reload: false
query5 4436 631 470 470
query6 329 224 212 212
query7 4232 459 259 259
query8 339 256 268 256
query9 8687 2834 2863 2834
query10 528 393 318 318
query11 15377 15201 14765 14765
query12 175 116 112 112
query13 1253 477 398 398
query14 6136 3035 2799 2799
query14_1 2671 2642 2677 2642
query15 206 199 179 179
query16 983 499 390 390
query17 1100 681 567 567
query18 2442 432 338 338
query19 224 217 194 194
query20 152 116 112 112
query21 209 132 121 121
query22 4090 4269 4228 4228
query23 15979 15576 15366 15366
query23_1 15521 15426 15562 15426
query24 7179 1586 1157 1157
query24_1 1209 1171 1191 1171
query25 521 424 375 375
query26 1103 261 146 146
query27 2766 447 274 274
query28 4545 2151 2127 2127
query29 719 530 411 411
query30 321 249 204 204
query31 763 634 612 612
query32 80 75 71 71
query33 514 377 308 308
query34 877 869 528 528
query35 736 755 675 675
query36 860 910 826 826
query37 126 92 84 84
query38 2684 2762 2712 2712
query39 792 748 734 734
query39_1 716 745 712 712
query40 214 137 116 116
query41 67 63 61 61
query42 103 101 97 97
query43 470 431 413 413
query44 1331 750 749 749
query45 185 190 178 178
query46 842 955 585 585
query47 1498 1502 1349 1349
query48 315 317 247 247
query49 607 435 341 341
query50 627 267 204 204
query51 3765 3814 3814 3814
query52 100 105 97 97
query53 286 328 270 270
query54 299 273 265 265
query55 83 84 75 75
query56 308 314 296 296
query57 1032 980 964 964
query58 269 256 254 254
query59 2107 2160 2124 2124
query60 335 340 314 314
query61 148 146 143 143
query62 375 355 329 329
query63 294 265 261 261
query64 4591 1255 1023 1023
query65 3854 3820 3737 3737
query66 1425 427 328 328
query67 15352 15501 15367 15367
query68 2417 1117 771 771
query69 463 370 332 332
query70 1022 969 915 915
query71 326 319 299 299
query72 5517 3573 3318 3318
query73 606 706 315 315
query74 8753 8766 8602 8602
query75 2760 2794 2452 2452
query76 2267 1054 652 652
query77 374 380 300 300
query78 9847 10036 9278 9278
query79 1071 917 583 583
query80 900 558 467 467
query81 543 260 231 231
query82 1272 145 112 112
query83 342 254 236 236
query84 247 117 96 96
query85 885 483 421 421
query86 361 301 297 297
query87 2845 2915 2729 2729
query88 3466 2591 2578 2578
query89 394 354 318 318
query90 1899 171 166 166
query91 173 160 139 139
query92 77 75 65 65
query93 926 903 546 546
query94 582 337 294 294
query95 589 387 309 309
query96 630 498 229 229
query97 2317 2407 2286 2286
query98 217 201 198 198
query99 589 581 506 506
Total cold run time: 246398 ms
Total hot run time: 174384 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3760492608
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #59927:
URL: https://github.com/apache/doris/pull/59927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3760312363
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (24/24)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59927_e3144674fc43c4e04727f9c1001f1d4b71765244_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59927_e3144674fc43c4e04727f9c1001f1d4b71765244_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.43% (25428/35597) |
| Line Coverage | 53.94% (265991/493152) |
| Region Coverage | 51.55% (220584/427864) |
| Branch Coverage | 52.98% (94742/178834) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3754906003
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (24/24)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59927_5b88993447922e7aafa54a610eeb42f6138b2542_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59927_5b88993447922e7aafa54a610eeb42f6138b2542_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.13% (25332/35122) |
| Line Coverage | 58.88% (265070/450198) |
| Region Coverage | 53.74% (220299/409905) |
| Branch Coverage | 55.32% (94455/170749) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3754361140
<details>
<summary>TPC-DS: <b>Total hot run time: 174544 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5b88993447922e7aafa54a610eeb42f6138b2542, data reload: false
query5 4766 624 486 486
query6 339 226 213 213
query7 4214 466 258 258
query8 337 243 242 242
query9 8720 2878 2871 2871
query10 537 384 345 345
query11 15204 15084 14919 14919
query12 196 118 114 114
query13 1243 470 387 387
query14 6551 3085 2822 2822
query14_1 2734 2728 2712 2712
query15 215 196 173 173
query16 1009 502 457 457
query17 1085 709 570 570
query18 2684 446 339 339
query19 225 226 197 197
query20 120 113 118 113
query21 216 142 118 118
query22 4176 4273 4069 4069
query23 16066 15926 15352 15352
query23_1 15410 15420 15599 15420
query24 7223 1562 1189 1189
query24_1 1211 1217 1204 1204
query25 569 468 422 422
query26 1242 274 156 156
query27 2738 450 281 281
query28 4529 2134 2127 2127
query29 783 565 468 468
query30 320 245 206 206
query31 794 626 598 598
query32 90 75 76 75
query33 530 365 322 322
query34 898 878 532 532
query35 730 765 692 692
query36 905 916 826 826
query37 136 97 87 87
query38 2730 2688 2656 2656
query39 808 759 740 740
query39_1 715 706 717 706
query40 219 135 117 117
query41 69 64 62 62
query42 104 100 105 100
query43 433 487 421 421
query44 1301 749 734 734
query45 187 184 173 173
query46 839 940 588 588
query47 1418 1446 1418 1418
query48 313 336 237 237
query49 601 426 354 354
query50 626 272 206 206
query51 3771 3848 3800 3800
query52 99 106 95 95
query53 292 331 270 270
query54 302 278 267 267
query55 87 78 78 78
query56 312 309 306 306
query57 983 1037 968 968
query58 268 259 264 259
query59 2054 2209 1978 1978
query60 339 332 327 327
query61 156 155 162 155
query62 407 362 315 315
query63 298 266 273 266
query64 4853 1316 1020 1020
query65 3789 3806 3725 3725
query66 1388 411 310 310
query67 15384 15489 15365 15365
query68 2480 1100 741 741
query69 446 364 328 328
query70 1016 955 852 852
query71 308 313 307 307
query72 5378 3186 3336 3186
query73 611 721 312 312
query74 8800 8727 8565 8565
query75 2777 2854 2483 2483
query76 2268 1055 667 667
query77 356 377 318 318
query78 9789 9919 9204 9204
query79 3040 851 579 579
query80 1734 603 483 483
query81 578 271 235 235
query82 976 144 113 113
query83 331 259 246 246
query84 266 118 88 88
query85 932 528 446 446
query86 496 326 298 298
query87 2892 2839 2777 2777
query88 3561 2543 2543 2543
query89 383 371 326 326
query90 1930 174 163 163
query91 168 168 141 141
query92 75 73 69 69
query93 1789 921 533 533
query94 658 324 292 292
query95 588 342 385 342
query96 649 503 229 229
query97 2352 2418 2369 2369
query98 235 197 195 195
query99 583 604 520 520
Total cold run time: 251488 ms
Total hot run time: 174544 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3754317075
<details>
<summary>TPC-H: <b>Total hot run time: 31353 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5b88993447922e7aafa54a610eeb42f6138b2542, data reload: false
------ Round 1 ----------------------------------
q1 17605 4234 4066 4066
q2 2055 355 238 238
q3 10152 1283 697 697
q4 10211 872 309 309
q5 7496 2102 1830 1830
q6 205 178 145 145
q7 944 792 642 642
q8 9294 1411 1122 1122
q9 5136 4626 4583 4583
q10 6803 1857 1401 1401
q11 534 288 269 269
q12 731 748 589 589
q13 17800 3832 3122 3122
q14 281 299 284 284
q15 595 522 506 506
q16 678 674 648 648
q17 655 767 521 521
q18 6741 6343 6307 6307
q19 1086 961 605 605
q20 391 353 256 256
q21 3023 2435 2265 2265
q22 1049 1006 948 948
Total cold run time: 103465 ms
Total hot run time: 31353 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4090 4048 4067 4048
q2 330 409 316 316
q3 2082 2592 2207 2207
q4 1333 1739 1362 1362
q5 4070 3968 4028 3968
q6 213 176 130 130
q7 1797 1841 1715 1715
q8 2851 2427 2447 2427
q9 7441 7210 7260 7210
q10 2531 2742 2355 2355
q11 561 465 444 444
q12 709 739 659 659
q13 3590 4170 3429 3429
q14 323 323 303 303
q15 538 517 517 517
q16 686 681 690 681
q17 1155 1405 1468 1405
q18 8327 7934 7767 7767
q19 844 835 853 835
q20 2011 2023 1853 1853
q21 4509 4287 4068 4068
q22 1061 1022 994 994
Total cold run time: 51052 ms
Total hot run time: 48693 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3754657326
# BE UT Coverage Report
Increment line coverage `100.00% (24/24)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5b88993447922e7aafa54a610eeb42f6138b2542_5b88993447922e7aafa54a610eeb42f6138b2542/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5b88993447922e7aafa54a610eeb42f6138b2542_5b88993447922e7aafa54a610eeb42f6138b2542/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.98% (18986/35839) |
| Line Coverage | 39.02% (175876/450783) |
| Region Coverage | 33.62% (136312/405397) |
| Branch Coverage | 34.65% (58897/169988) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3760492387
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3753907498
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3760000310
# BE UT Coverage Report
Increment line coverage `100.00% (24/24)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e3144674fc43c4e04727f9c1001f1d4b71765244_e3144674fc43c4e04727f9c1001f1d4b71765244/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e3144674fc43c4e04727f9c1001f1d4b71765244_e3144674fc43c4e04727f9c1001f1d4b71765244/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.43% (19042/36319) |
| Line Coverage | 35.74% (176461/493734) |
| Region Coverage | 32.29% (136683/423362) |
| Branch Coverage | 33.17% (59067/178073) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3759794831
<details>
<summary>ClickBench: <b>Total hot run time: 26.5 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e3144674fc43c4e04727f9c1001f1d4b71765244, data reload: false
query1 0.05 0.05 0.05
query2 0.10 0.05 0.05
query3 0.25 0.08 0.08
query4 1.60 0.12 0.11
query5 0.28 0.25 0.25
query6 1.15 0.70 0.66
query7 0.03 0.02 0.03
query8 0.05 0.04 0.04
query9 0.56 0.50 0.50
query10 0.55 0.54 0.55
query11 0.15 0.09 0.10
query12 0.14 0.10 0.11
query13 0.61 0.58 0.60
query14 0.94 0.93 0.94
query15 0.79 0.78 0.77
query16 0.39 0.43 0.43
query17 1.01 1.04 1.08
query18 0.23 0.22 0.21
query19 1.89 1.70 1.82
query20 0.02 0.01 0.01
query21 15.45 0.25 0.14
query22 5.31 0.05 0.05
query23 15.78 0.30 0.10
query24 1.96 0.24 0.18
query25 0.14 0.05 0.04
query26 0.14 0.15 0.13
query27 0.07 0.06 0.07
query28 4.11 1.08 0.88
query29 12.58 3.93 3.14
query30 0.27 0.15 0.12
query31 2.82 0.63 0.38
query32 3.24 0.56 0.46
query33 2.95 2.98 3.03
query34 16.24 5.16 4.41
query35 4.50 4.49 4.43
query36 0.65 0.51 0.49
query37 0.11 0.07 0.07
query38 0.08 0.04 0.03
query39 0.05 0.03 0.03
query40 0.16 0.14 0.13
query41 0.09 0.04 0.03
query42 0.05 0.03 0.02
query43 0.04 0.04 0.04
Total cold run time: 97.58 s
Total hot run time: 26.5 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](rle) Refactor RLE for writing long runs of repeated values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59927:
URL: https://github.com/apache/doris/pull/59927#issuecomment-3759743076
<details>
<summary>TPC-H: <b>Total hot run time: 32458 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e3144674fc43c4e04727f9c1001f1d4b71765244, data reload: false
------ Round 1 ----------------------------------
q1 17600 4318 4110 4110
q2 2102 355 239 239
q3 10130 1273 728 728
q4 10191 822 310 310
q5 7459 2074 1908 1908
q6 194 168 137 137
q7 923 800 662 662
q8 9275 1345 1115 1115
q9 5121 4681 4759 4681
q10 6833 1827 1432 1432
q11 518 307 287 287
q12 743 755 619 619
q13 17793 3868 3092 3092
q14 297 300 276 276
q15 588 524 515 515
q16 688 708 652 652
q17 654 794 526 526
q18 6718 6482 6978 6482
q19 1944 1088 677 677
q20 415 417 268 268
q21 3265 2743 2687 2687
q22 1146 1129 1055 1055
Total cold run time: 104597 ms
Total hot run time: 32458 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4408 4373 4392 4373
q2 335 406 322 322
q3 2304 2869 2486 2486
q4 1450 1968 1432 1432
q5 4528 4411 4287 4287
q6 221 166 124 124
q7 1915 2020 1747 1747
q8 2574 2454 2384 2384
q9 7204 7067 7331 7067
q10 2591 2894 2188 2188
q11 529 457 443 443
q12 655 710 577 577
q13 3367 3795 3114 3114
q14 287 304 267 267
q15 535 487 480 480
q16 625 667 622 622
q17 1125 1301 1298 1298
q18 7142 7445 7504 7445
q19 827 788 780 780
q20 1882 1927 1853 1853
q21 4639 4219 4147 4147
q22 1104 1006 972 972
Total cold run time: 50247 ms
Total hot run time: 48408 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org