You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2024/10/10 07:07:41 UTC
[PR] [feature](array_agg) support array_agg with param is array/map/struct… [doris]
amorynan opened a new pull request, #41651:
URL: https://github.com/apache/doris/pull/41651
… (#40697)
this pr we support array_agg function support param with array map struct type
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](array_agg) support array_agg with param is array/map/struct… [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41651:
URL: https://github.com/apache/doris/pull/41651#discussion_r1794822362
##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -505,6 +505,71 @@ struct AggregateFunctionArrayAggData<StringRef> {
}
};
+template <>
+struct AggregateFunctionArrayAggData<void> {
+ using ElementType = StringRef;
+ using Self = AggregateFunctionArrayAggData<void>;
+ MutableColumnPtr column_data;
+
+ AggregateFunctionArrayAggData() {}
Review Comment:
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
```suggestion
AggregateFunctionArrayAggData() = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](array_agg) support array_agg with param is array/map/struct… [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #41651:
URL: https://github.com/apache/doris/pull/41651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](array_agg) support array_agg with param is array/map/struct… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41651:
URL: https://github.com/apache/doris/pull/41651#issuecomment-2404293725
TeamCity be ut coverage result:
Function Coverage: 36.08% (9340/25886)
Line Coverage: 27.66% (76730/277406)
Region Coverage: 26.45% (39391/148931)
Branch Coverage: 23.24% (20042/86250)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c619261f2eacf5985aa2a5062bde1661569359e2_c619261f2eacf5985aa2a5062bde1661569359e2/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](array_agg) support array_agg with param is array/map/struct… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41651:
URL: https://github.com/apache/doris/pull/41651#issuecomment-2404227301
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](array_agg) support array_agg with param is array/map/struct… [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #41651:
URL: https://github.com/apache/doris/pull/41651#issuecomment-2404227444
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org