You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/06 15:46:05 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new pull request #10683: fix datasource config error for #10584

RaigorJiang opened a new pull request #10683:
URL: https://github.com/apache/shardingsphere/pull/10683


   fix datasource config error for #10584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10683: fix datasource config error for #10584

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10683:
URL: https://github.com/apache/shardingsphere/pull/10683#issuecomment-855427428


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10683?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10683](https://codecov.io/gh/apache/shardingsphere/pull/10683?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db56c1a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1292181683e0f2676aac6382c90014be03dfc6ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1292181) will **increase** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10683/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10683?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10683      +/-   ##
   ============================================
   + Coverage     64.97%   65.07%   +0.09%     
     Complexity      688      688              
   ============================================
     Files          1776     1773       -3     
     Lines         30633    30643      +10     
     Branches       5504     5506       +2     
   ============================================
   + Hits          19905    19940      +35     
   + Misses         9153     9126      -27     
   - Partials       1575     1577       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10683?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../metadata/schema/builder/TableMetaDataBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvYnVpbGRlci9UYWJsZU1ldGFEYXRhQnVpbGRlci5qYXZh) | `90.00% <0.00%> (ø)` | |
   | [...ized/loader/RewriteAssertionsRootEntityLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLXRlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3Jld3JpdGUvcGFyYW1ldGVyaXplZC9sb2FkZXIvUmV3cml0ZUFzc2VydGlvbnNSb290RW50aXR5TG9hZGVyLmphdmE=) | | |
   | [...ameterized/entity/RewriteAssertionsRootEntity.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLXRlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3Jld3JpdGUvcGFyYW1ldGVyaXplZC9lbnRpdHkvUmV3cml0ZUFzc2VydGlvbnNSb290RW50aXR5LmphdmE=) | | |
   | [...gine/parameter/SQLRewriteEngineTestParameters.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLXRlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3Jld3JpdGUvcGFyYW1ldGVyaXplZC9lbmdpbmUvcGFyYW1ldGVyL1NRTFJld3JpdGVFbmdpbmVUZXN0UGFyYW1ldGVycy5qYXZh) | | |
   | [...rameter/SQLRewriteEngineTestParametersBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLXRlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3Jld3JpdGUvcGFyYW1ldGVyaXplZC9lbmdpbmUvcGFyYW1ldGVyL1NRTFJld3JpdGVFbmdpbmVUZXN0UGFyYW1ldGVyc0J1aWxkZXIuamF2YQ==) | | |
   | [...nfra/metadata/engine/MetadataRefresherFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9lbmdpbmUvTWV0YWRhdGFSZWZyZXNoZXJGYWN0b3J5LmphdmE=) | | |
   | [...ra/optimize/core/schema/FederateTableMetadata.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvcmUvc2NoZW1hL0ZlZGVyYXRlVGFibGVNZXRhZGF0YS5qYXZh) | | |
   | [...e/infra/metadata/engine/MetadataRefreshEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9lbmdpbmUvTWV0YWRhdGFSZWZyZXNoRW5naW5lLmphdmE=) | | |
   | [...a/optimize/core/schema/FederateSchemaMetadata.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvcmUvc2NoZW1hL0ZlZGVyYXRlU2NoZW1hTWV0YWRhdGEuamF2YQ==) | | |
   | [.../optimize/core/schema/FederateSchemaMetadatas.java](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvcmUvc2NoZW1hL0ZlZGVyYXRlU2NoZW1hTWV0YWRhdGFzLmphdmE=) | | |
   | ... and [12 more](https://codecov.io/gh/apache/shardingsphere/pull/10683/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10683?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10683?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1292181...db56c1a](https://codecov.io/gh/apache/shardingsphere/pull/10683?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #10683: fix datasource config error for #10584

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #10683:
URL: https://github.com/apache/shardingsphere/pull/10683


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org