You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/04 11:16:57 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request #14512: Remove unnecessary static.
yx9o opened a new pull request #14512:
URL: https://github.com/apache/shardingsphere/pull/14512
Remove unnecessary static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #14512: Remove unnecessary static.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #14512:
URL: https://github.com/apache/shardingsphere/pull/14512#issuecomment-1004851946
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14512?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14512](https://codecov.io/gh/apache/shardingsphere/pull/14512?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (296f229) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8cdac04b7d34196df8cd6abdda0ff395e6b8a3ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cdac04) will **not change** coverage.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/14512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14512 +/- ##
=========================================
Coverage 59.89% 59.89%
Complexity 1810 1810
=========================================
Files 2989 2989
Lines 44446 44446
Branches 7544 7544
=========================================
Hits 26619 26619
Misses 15765 15765
Partials 2062 2062
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/14512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ler/query/DatabaseDiscoveryRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/14512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9EYXRhYmFzZURpc2NvdmVyeVJ1bGVRdWVyeVJlc3VsdFNldC5qYXZh) | `80.76% <50.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14512?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14512?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [62b971a...296f229](https://codecov.io/gh/apache/shardingsphere/pull/14512?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o closed pull request #14512: Remove unnecessary static.
Posted by GitBox <gi...@apache.org>.
yx9o closed pull request #14512:
URL: https://github.com/apache/shardingsphere/pull/14512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on pull request #14512: Remove unnecessary static.
Posted by GitBox <gi...@apache.org>.
yx9o commented on pull request #14512:
URL: https://github.com/apache/shardingsphere/pull/14512#issuecomment-1005421684
> It is better to use static here, the variable is class based
Ok, I will close this pr, do getColumnNames in other QueryResultSet classes need to be adjusted to static?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org