You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/23 16:09:44 UTC

[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #626: feat: add Zh Blogs

KishaniKandasamy opened a new pull request #626:
URL: https://github.com/apache/apisix-website/pull/626


   Fixes: #623
   
   Changes:
   
   made changes according to https://www.docusaurus.cn/docs/api/plugins/@docusaurus/plugin-content-blog#i18n
   
   Please review when you are available @juzhiyuan @liuxiran  @bzp2010 @Baoyuantop 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-960398654


   Hi @KishaniKandasamy, thanks for your continuous contrition! I have translated all necessary blogs in #681 #682 #679 #678 from Chinese to English, so I will close this PR and #550 :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Baoyuantop commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-928718521


   Hi @KishaniKandasamy, In general, there are a few things that need to be changed:
   
   1. All blog content should both exist in the `blog` and `i18n/zh/docusaurus-plugin-content-blog` directories.
   
   2. Because the website is in English by default, the blogs in the `blog` directory should all be in English, but we have not yet completed the overall translation, so the Chinese blogs in this directory need to be marked as `draft`, refer to: https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter
   
   3. Similarly, the blogs in the `i18n/zh/docusaurus-plugin-content-blog` directory should all be in Chinese, so we need to mark all the English blogs in this directory as `draft`.
   
   We need to complete the translation of the blog marked as `draft` in the future, and then cancel the draft mark.
   
   What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-926703168


   > Does it seem that no matter if I change Chinese or English, the blog is always displayed in English？
   
   Yes. just rechecked this https://www.docusaurus.cn/docs/api/plugins/@docusaurus/plugin-content-blog#i18n .
   Please let me know if there is any change to be done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan closed pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #626:
URL: https://github.com/apache/apisix-website/pull/626


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Baoyuantop commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-926256149


   Does it seem that no matter if I change Chinese or English, the blog is always displayed in English？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Baoyuantop commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-927088515


   In #623, the Expected Behaviour is: 
   When the current environment is in English, only English blogs are displayed, and in the Chinese environment, only Chinese blogs are displayed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-928846417


   > Hi @KishaniKandasamy, In general, there are a few things that need to be changed:
   > 
   > 1. All blog content should both exist in the `blog` and `i18n/zh/docusaurus-plugin-content-blog` directories.
   > 2. Because the website is in English by default, the blogs in the `blog` directory should all be in English, but we have not yet completed the overall translation, so the Chinese blogs in this directory need to be marked as `draft`, refer to: https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter
   > 3. Similarly, the blogs in the `i18n/zh/docusaurus-plugin-content-blog` directory should all be in Chinese, so we need to mark all the English blogs in this directory as `draft`.
   > 
   > We need to complete the translation of the blog marked as `draft` in the future, and then cancel the draft mark.
   > 
   > What do you think?
   
   I got it @Baoyuantop .Many thanks for this clarification! I'm gonna make this changes now:)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] yzeng25 commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
yzeng25 commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-945259238


   Hi @KishaniKandasamy @Baoyuantop , are you guys still working on this PR and https://github.com/apache/apisix-website/pull/550? Or maybe you can close it since it is done in https://github.com/apache/apisix-website/pull/634. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-927099109


   > In #623, the Expected Behaviour is:
   > When the current environment is in English, only English blogs are displayed, and in the Chinese environment, only Chinese blogs are displayed.
   
   yes For this behavior I followed this guide https://www.docusaurus.cn/docs/api/plugins/@docusaurus/plugin-content-blog#i18n


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Baoyuantop commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-927213841


   cc @guoqqqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy edited a comment on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy edited a comment on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-928846417


   > Hi @KishaniKandasamy, In general, there are a few things that need to be changed:
   > 
   > 1. All blog content should both exist in the `blog` and `i18n/zh/docusaurus-plugin-content-blog` directories.
   > 2. Because the website is in English by default, the blogs in the `blog` directory should all be in English, but we have not yet completed the overall translation, so the Chinese blogs in this directory need to be marked as `draft`, refer to: https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter
   > 3. Similarly, the blogs in the `i18n/zh/docusaurus-plugin-content-blog` directory should all be in Chinese, so we need to mark all the English blogs in this directory as `draft`.
   > 
   > We need to complete the translation of the blog marked as `draft` in the future, and then cancel the draft mark.
   > 
   > What do you think?
   
   I got it @Baoyuantop .Many thanks for this clarification! I'm gonna make this changes :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-930137146


   Hi @Baoyuantop , I have submitted another [PR ](https://github.com/apache/apisix-website/pull/634)for this task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-930137146


   Hi @Baoyuantop , I have submitted another [PR ](https://github.com/apache/apisix-website/pull/634)for this task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-927108533


   > Does it seem that no matter if I change Chinese or English, the blog is always displayed in English？
   
   Yes ;(
   ![Screenshot 2021-09-25 170633](https://user-images.githubusercontent.com/53715187/134770090-4144f197-236b-4d4c-9642-ac1d32144dae.jpg)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy edited a comment on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy edited a comment on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-927099109


   > In #623, the Expected Behaviour is:
   > When the current environment is in English, only English blogs are displayed, and in the Chinese environment, only Chinese blogs are displayed.
   
   yes For this behavior I followed this guide https://www.docusaurus.cn/docs/api/plugins/@docusaurus/plugin-content-blog#i18n & will look into that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Baoyuantop commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-928718521


   Hi @KishaniKandasamy, In general, there are a few things that need to be changed:
   
   1. All blog content should both exist in the `blog` and `i18n/zh/docusaurus-plugin-content-blog` directories.
   
   2. Because the website is in English by default, the blogs in the `blog` directory should all be in English, but we have not yet completed the overall translation, so the Chinese blogs in this directory need to be marked as `draft`, refer to: https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter
   
   3. Similarly, the blogs in the `i18n/zh/docusaurus-plugin-content-blog` directory should all be in Chinese, so we need to mark all the English blogs in this directory as `draft`.
   
   We need to complete the translation of the blog marked as `draft` in the future, and then cancel the draft mark.
   
   What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-928846417


   > Hi @KishaniKandasamy, In general, there are a few things that need to be changed:
   > 
   > 1. All blog content should both exist in the `blog` and `i18n/zh/docusaurus-plugin-content-blog` directories.
   > 2. Because the website is in English by default, the blogs in the `blog` directory should all be in English, but we have not yet completed the overall translation, so the Chinese blogs in this directory need to be marked as `draft`, refer to: https://docusaurus.io/zh-CN/docs/api/plugins/@docusaurus/plugin-content-blog#markdown-frontmatter
   > 3. Similarly, the blogs in the `i18n/zh/docusaurus-plugin-content-blog` directory should all be in Chinese, so we need to mark all the English blogs in this directory as `draft`.
   > 
   > We need to complete the translation of the blog marked as `draft` in the future, and then cancel the draft mark.
   > 
   > What do you think?
   
   I got it @Baoyuantop .Many thanks for this clarification! I'm gonna make this changes now:)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #626: feat: add Zh Blogs

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #626:
URL: https://github.com/apache/apisix-website/pull/626#issuecomment-945348351


   > Hi @KishaniKandasamy @Baoyuantop , are you guys still working on this PR and #550? Or maybe you can close it since it is done in #634. Thanks!
   
   Hi @Baoyuantop We can close it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org