You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/27 22:17:29 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
rkhachatryan opened a new pull request #12365:
URL: https://github.com/apache/flink/pull/12365
## What is the purpose of the change
The underlying state handles of channel state handles can be the same.
Discard should only iterate over unique underlying handles.
## Verifying this change
This change added `OperatorSubtaskStateTest.testDiscardDuplicatedDelegatesOnce` (unit test).
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12365:
URL: https://github.com/apache/flink/pull/12365#issuecomment-634981483
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbdee39abdb6795fb67caeb907adf0f9d2619d8b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12365:
URL: https://github.com/apache/flink/pull/12365#issuecomment-634981483
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308",
"triggerID" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbdee39abdb6795fb67caeb907adf0f9d2619d8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12365:
URL: https://github.com/apache/flink/pull/12365#issuecomment-634981483
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308",
"triggerID" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"triggerType" : "PUSH"
}, {
"hash" : "74a2a8ec4d2d6510b67af3705d2a0bf50f05ab3e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2340",
"triggerID" : "74a2a8ec4d2d6510b67af3705d2a0bf50f05ab3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbdee39abdb6795fb67caeb907adf0f9d2619d8b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308)
* 74a2a8ec4d2d6510b67af3705d2a0bf50f05ab3e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2340)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12365:
URL: https://github.com/apache/flink/pull/12365#issuecomment-634981483
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308",
"triggerID" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"triggerType" : "PUSH"
}, {
"hash" : "74a2a8ec4d2d6510b67af3705d2a0bf50f05ab3e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74a2a8ec4d2d6510b67af3705d2a0bf50f05ab3e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbdee39abdb6795fb67caeb907adf0f9d2619d8b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308)
* 74a2a8ec4d2d6510b67af3705d2a0bf50f05ab3e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #12365:
URL: https://github.com/apache/flink/pull/12365#discussion_r431629099
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java
##########
@@ -231,8 +232,7 @@ public void discardState() {
toDispose.addAll(rawOperatorState);
toDispose.addAll(managedKeyedState);
toDispose.addAll(rawKeyedState);
- toDispose.addAll(inputChannelState);
- toDispose.addAll(resultSubpartitionState);
+ toDispose.addAll(collectUniqueDelegates(inputChannelState, resultSubpartitionState));
Review comment:
Totally agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12365:
URL: https://github.com/apache/flink/pull/12365#issuecomment-634974336
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fbdee39abdb6795fb67caeb907adf0f9d2619d8b (Wed May 27 22:21:05 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12365:
URL: https://github.com/apache/flink/pull/12365#issuecomment-634981483
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308",
"triggerID" : "fbdee39abdb6795fb67caeb907adf0f9d2619d8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbdee39abdb6795fb67caeb907adf0f9d2619d8b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2308)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #12365:
URL: https://github.com/apache/flink/pull/12365#discussion_r431606416
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java
##########
@@ -231,8 +232,7 @@ public void discardState() {
toDispose.addAll(rawOperatorState);
toDispose.addAll(managedKeyedState);
toDispose.addAll(rawKeyedState);
- toDispose.addAll(inputChannelState);
- toDispose.addAll(resultSubpartitionState);
+ toDispose.addAll(collectUniqueDelegates(inputChannelState, resultSubpartitionState));
Review comment:
I think that's another place that would be better with FLINK-17972 - we could hide this logic inside the encapsulating `InFlightChannelStateHandle#discardState`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org