You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/07/20 14:17:59 UTC
[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #6990: Introduce SQL array function: array has
izveigor commented on code in PR #6990:
URL: https://github.com/apache/arrow-datafusion/pull/6990#discussion_r1269531286
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -2267,63 +2267,6 @@ mod tests {
assert_eq!(result, &UInt64Array::from_value(2, 1));
}
- #[test]
Review Comment:
Sqllogictests are more important than unit tests: unit tests are mainly for convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org