[GitHub] [daffodil] mike-mcgann commented on pull request #981: Update parsing when emptyValueDelimiterPolicy is 'none'

["mike-mcgann (via GitHub)" <gi...@apache.org>]

mike-mcgann commented on PR #981:
URL: https://github.com/apache/daffodil/pull/981#issuecomment-1460749045

   > I'm not sure how we currently implement things though, or maybe those other policies are broken too?
   
   I started with the original ticket, placed that test case in (in the form that I thought it wanted), verified that the error was the one described in the ticket, and worked from there trying to get the test to pass. I didn't find an obvious place in the code where these other cases were being handled so I focused on getting the 'none' case to work first. Once that was working, I then suspected that the other cases may not be handled since I didn't run across them. I added those additional cases as tests and some of them didn't work. I then made some additional changes to get those to pass. 
   
   I just pulled the latest from main and copied over the new tests there to see what the results would be. Only the 'both' test passed--the 'initiator', 'terminator', and 'none' tests failed. So I don't think the emptyValueDelimiterPolicy got put in or in a way that was exercised by the tests. 
   
   Also, I don't have a grasp on the details of the parsing at the moment so I'm making most of my changes through trial and error and seeing what that fixes and what that breaks. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org