You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Szabolcs Vasas <va...@gmail.com> on 2018/08/16 14:37:07 UTC
Review Request 68382: Upgrade Gradle version to 4.9
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68382/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3364
https://issues.apache.org/jira/browse/SQOOP-3364
Repository: sqoop-trunk
Description
-------
Apart from the Gradle version bump the change contains the following:
- html.destination type is modified to file to avoid deprecation warning
- the task wrapper is replaced with wrapper {} to avoid deprecation warning
- enableFeaturePreview('STABLE_PUBLISHING') is added to settings.gradle to avoid deprecation warning. This is a change I could not test since we cannot publish to maven repo now. However in a case of a future release we should test it as described here: https://docs.gradle.org/4.9/userguide/publishing_maven.html#publishing_maven:deferred_configuration
- The HBase test cases failed at first because the regionserver web ui was not able to start up most probably because of a bad version of a Jetty class on the classpath. However we do not need the regionserver web ui for the Sqoop tests so instead of playing around with libraries I disabled it just like we have already disabled the master web ui.
Diffs
-----
build.gradle 709172cc0
gradle/wrapper/gradle-wrapper.jar 99340b4ad18d3c7e764794d300ffd35017036793
gradle/wrapper/gradle-wrapper.properties 90a06cec7
settings.gradle 7d64af500
src/test/org/apache/sqoop/hbase/HBaseTestCase.java 87fce34a8
Diff: https://reviews.apache.org/r/68382/diff/1/
Testing
-------
Executed unit and third party test suite successfully.
Thanks,
Szabolcs Vasas
Re: Review Request 68382: Upgrade Gradle version to 4.9
Posted by Szabolcs Vasas <va...@gmail.com>.
> On Aug. 21, 2018, 3:49 p.m., daniel voros wrote:
> > Thank you for picking this up! I've checked the following:
> > - tar.gz contents (and lib/ in particular) are the same when generated with `./gradlew tar -x test`
> > - publishing of snapshot and released artifacts works with local and remote repositories
> >
> > I couldn't get the ant way of publishing to work with remote repositories but comparing to the Maven central I've noticed that we've only released 1.4.7 with the classifier `hadoop260`. This is something we might need to revisit when deploying the next release; whether it makes sense to add a classifier if we're only releasing a single version. (For 1.4.6 there were multiple versions: http://central.maven.org/maven2/org/apache/sqoop/sqoop/1.4.6/)
Great, thank you for looking at it!
Yes, I agree, we should not use classifiers if there are only one version.
- Szabolcs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68382/#review207668
-----------------------------------------------------------
On Aug. 16, 2018, 2:37 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68382/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3364
> https://issues.apache.org/jira/browse/SQOOP-3364
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Apart from the Gradle version bump the change contains the following:
> - html.destination type is modified to file to avoid deprecation warning
> - the task wrapper is replaced with wrapper {} to avoid deprecation warning
> - enableFeaturePreview('STABLE_PUBLISHING') is added to settings.gradle to avoid deprecation warning. This is a change I could not test since we cannot publish to maven repo now. However in a case of a future release we should test it as described here: https://docs.gradle.org/4.9/userguide/publishing_maven.html#publishing_maven:deferred_configuration
> - The HBase test cases failed at first because the regionserver web ui was not able to start up most probably because of a bad version of a Jetty class on the classpath. However we do not need the regionserver web ui for the Sqoop tests so instead of playing around with libraries I disabled it just like we have already disabled the master web ui.
>
>
> Diffs
> -----
>
> build.gradle 709172cc0
> gradle/wrapper/gradle-wrapper.jar 99340b4ad18d3c7e764794d300ffd35017036793
> gradle/wrapper/gradle-wrapper.properties 90a06cec7
> settings.gradle 7d64af500
> src/test/org/apache/sqoop/hbase/HBaseTestCase.java 87fce34a8
>
>
> Diff: https://reviews.apache.org/r/68382/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party test suite successfully.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 68382: Upgrade Gradle version to 4.9
Posted by daniel voros <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68382/#review207668
-----------------------------------------------------------
Ship it!
Thank you for picking this up! I've checked the following:
- tar.gz contents (and lib/ in particular) are the same when generated with `./gradlew tar -x test`
- publishing of snapshot and released artifacts works with local and remote repositories
I couldn't get the ant way of publishing to work with remote repositories but comparing to the Maven central I've noticed that we've only released 1.4.7 with the classifier `hadoop260`. This is something we might need to revisit when deploying the next release; whether it makes sense to add a classifier if we're only releasing a single version. (For 1.4.6 there were multiple versions: http://central.maven.org/maven2/org/apache/sqoop/sqoop/1.4.6/)
- daniel voros
On Aug. 16, 2018, 2:37 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68382/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3364
> https://issues.apache.org/jira/browse/SQOOP-3364
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Apart from the Gradle version bump the change contains the following:
> - html.destination type is modified to file to avoid deprecation warning
> - the task wrapper is replaced with wrapper {} to avoid deprecation warning
> - enableFeaturePreview('STABLE_PUBLISHING') is added to settings.gradle to avoid deprecation warning. This is a change I could not test since we cannot publish to maven repo now. However in a case of a future release we should test it as described here: https://docs.gradle.org/4.9/userguide/publishing_maven.html#publishing_maven:deferred_configuration
> - The HBase test cases failed at first because the regionserver web ui was not able to start up most probably because of a bad version of a Jetty class on the classpath. However we do not need the regionserver web ui for the Sqoop tests so instead of playing around with libraries I disabled it just like we have already disabled the master web ui.
>
>
> Diffs
> -----
>
> build.gradle 709172cc0
> gradle/wrapper/gradle-wrapper.jar 99340b4ad18d3c7e764794d300ffd35017036793
> gradle/wrapper/gradle-wrapper.properties 90a06cec7
> settings.gradle 7d64af500
> src/test/org/apache/sqoop/hbase/HBaseTestCase.java 87fce34a8
>
>
> Diff: https://reviews.apache.org/r/68382/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party test suite successfully.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 68382: Upgrade Gradle version to 4.9
Posted by Szabolcs Vasas <va...@gmail.com>.
> On Aug. 22, 2018, 2:20 p.m., Nguyen Truong wrote:
> > Hi Szabolcs,
> >
> > Thanks for taking care of this.
> >
> > The test PostgresMetaConnectIncrementalImportTest failed when I ran the third party test suite but succeeded when I ran it again alone. I guess it was not because of your patch though.
> >
> > Best,
> > Nguyen
Thank you for reviewing my patch!
Yes, PostgresMetaConnectIncrementalImportTest seems to be flaky I have seen it failing earlier as well with Gradle.
This is something we will probably need to investigate in another JIRA.
- Szabolcs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68382/#review207747
-----------------------------------------------------------
On Aug. 16, 2018, 2:37 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68382/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3364
> https://issues.apache.org/jira/browse/SQOOP-3364
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Apart from the Gradle version bump the change contains the following:
> - html.destination type is modified to file to avoid deprecation warning
> - the task wrapper is replaced with wrapper {} to avoid deprecation warning
> - enableFeaturePreview('STABLE_PUBLISHING') is added to settings.gradle to avoid deprecation warning. This is a change I could not test since we cannot publish to maven repo now. However in a case of a future release we should test it as described here: https://docs.gradle.org/4.9/userguide/publishing_maven.html#publishing_maven:deferred_configuration
> - The HBase test cases failed at first because the regionserver web ui was not able to start up most probably because of a bad version of a Jetty class on the classpath. However we do not need the regionserver web ui for the Sqoop tests so instead of playing around with libraries I disabled it just like we have already disabled the master web ui.
>
>
> Diffs
> -----
>
> build.gradle 709172cc0
> gradle/wrapper/gradle-wrapper.jar 99340b4ad18d3c7e764794d300ffd35017036793
> gradle/wrapper/gradle-wrapper.properties 90a06cec7
> settings.gradle 7d64af500
> src/test/org/apache/sqoop/hbase/HBaseTestCase.java 87fce34a8
>
>
> Diff: https://reviews.apache.org/r/68382/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party test suite successfully.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 68382: Upgrade Gradle version to 4.9
Posted by Nguyen Truong <ng...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68382/#review207747
-----------------------------------------------------------
Ship it!
Hi Szabolcs,
Thanks for taking care of this.
The test PostgresMetaConnectIncrementalImportTest failed when I ran the third party test suite but succeeded when I ran it again alone. I guess it was not because of your patch though.
Best,
Nguyen
- Nguyen Truong
On Aug. 16, 2018, 2:37 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68382/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 2:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3364
> https://issues.apache.org/jira/browse/SQOOP-3364
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Apart from the Gradle version bump the change contains the following:
> - html.destination type is modified to file to avoid deprecation warning
> - the task wrapper is replaced with wrapper {} to avoid deprecation warning
> - enableFeaturePreview('STABLE_PUBLISHING') is added to settings.gradle to avoid deprecation warning. This is a change I could not test since we cannot publish to maven repo now. However in a case of a future release we should test it as described here: https://docs.gradle.org/4.9/userguide/publishing_maven.html#publishing_maven:deferred_configuration
> - The HBase test cases failed at first because the regionserver web ui was not able to start up most probably because of a bad version of a Jetty class on the classpath. However we do not need the regionserver web ui for the Sqoop tests so instead of playing around with libraries I disabled it just like we have already disabled the master web ui.
>
>
> Diffs
> -----
>
> build.gradle 709172cc0
> gradle/wrapper/gradle-wrapper.jar 99340b4ad18d3c7e764794d300ffd35017036793
> gradle/wrapper/gradle-wrapper.properties 90a06cec7
> settings.gradle 7d64af500
> src/test/org/apache/sqoop/hbase/HBaseTestCase.java 87fce34a8
>
>
> Diff: https://reviews.apache.org/r/68382/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party test suite successfully.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>