[jira] [Comment Edited] (BATCHEE-48) ItemProcessListener.onProcessError() gets called with 'processedItem' instead of 'itemRead'

["Scott Kurz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BATCHEE-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108398#comment-14108398 ] 

Scott Kurz edited comment on BATCHEE-48 at 8/24/14 10:43 AM:
-------------------------------------------------------------

Just wanted to note that this Javadoc has been fixed in the 1.0 RevA maintenance release to reflect the conclusion of this JIRA.

It now reads:

/**
* The onProcessError method receives control after an 
* item processor processItem throws an exception. The method 
* receives the item sent to the item processor as input. 
* @param item specifies the item the processor attempted to process.
....




was (Author: scottkurz):
Just wanted to note that this Javadoc has been fixed in the 1.0_RevA maintenance release.

It now reads:


> ItemProcessListener.onProcessError() gets called with 'processedItem' instead of 'itemRead'
> -------------------------------------------------------------------------------------------
>
>                 Key: BATCHEE-48
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-48
>             Project: BatchEE
>          Issue Type: Bug
>    Affects Versions: 0.2-incubating
>            Reporter: Alonso Gonzalez
>            Assignee: Romain Manni-Bucau
>             Fix For: 0.2-incubating
>
>
> In case of an exception, ChunkStepController calls ItemProcessListener.onProcessError with 'processedItem'. But processedItem will be always 'null' unless the process method finishes without an exception.
> The specification states that 'the item about to be processed' should be passed:
> {quote}
> /**
> * The afterProcess method receives control after an item
> * processor processes an item. The method receives the item processed
> * and the result item as an input.
> * @param item specifies the item about to be processed.
> * @param ex specifies the exception thrown by the item processor.
> * @throws Exception
> */
> public void onProcessError(Object item, Exception ex) throws Exception;
> {quote}
> (Obviously the first part of the JavaDoc has been accidentally copied from the 'afterProcess' method.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)