You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dh...@apache.org on 2016/11/07 19:41:07 UTC

[1/3] incubator-beam git commit: Disable all broken findbugs builds and link to JIRA issues

Repository: incubator-beam
Updated Branches:
  refs/heads/master 110245526 -> b5f847355


Disable all broken findbugs builds and link to JIRA issues


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/e1291eea
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/e1291eea
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/e1291eea

Branch: refs/heads/master
Commit: e1291eea9e21dce4df44245d53a78664003c264a
Parents: fae52a3
Author: Dan Halperin <dh...@google.com>
Authored: Mon Nov 7 09:54:04 2016 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Mon Nov 7 10:43:11 2016 -0800

----------------------------------------------------------------------
 examples/java/pom.xml                                  | 13 +++++++++++++
 examples/java8/pom.xml                                 | 13 +++++++++++++
 runners/core-java/pom.xml                              | 12 ++++++++++++
 runners/direct-java/pom.xml                            | 13 +++++++++++++
 runners/flink/pom.xml                                  |  9 +++++++++
 runners/google-cloud-dataflow-java/pom.xml             | 13 +++++++++++++
 runners/spark/pom.xml                                  |  9 +++++++++
 .../apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java    |  4 ++--
 sdks/java/io/jms/pom.xml                               | 13 +++++++++++++
 sdks/java/io/kafka/pom.xml                             | 13 +++++++++++++
 sdks/java/io/kinesis/pom.xml                           | 13 +++++++++++++
 sdks/java/io/mongodb/pom.xml                           | 13 +++++++++++++
 sdks/java/microbenchmarks/pom.xml                      | 13 +++++++++++++
 13 files changed, 149 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/examples/java/pom.xml
----------------------------------------------------------------------
diff --git a/examples/java/pom.xml b/examples/java/pom.xml
index 5d69bfe..6d18a0f 100644
--- a/examples/java/pom.xml
+++ b/examples/java/pom.xml
@@ -260,6 +260,19 @@
   </profiles>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-933 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/examples/java8/pom.xml
----------------------------------------------------------------------
diff --git a/examples/java8/pom.xml b/examples/java8/pom.xml
index 72f24ca..8591955 100644
--- a/examples/java8/pom.xml
+++ b/examples/java8/pom.xml
@@ -118,6 +118,19 @@
   </profiles>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-934 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/runners/core-java/pom.xml
----------------------------------------------------------------------
diff --git a/runners/core-java/pom.xml b/runners/core-java/pom.xml
index 40ebf58..aa5f145 100644
--- a/runners/core-java/pom.xml
+++ b/runners/core-java/pom.xml
@@ -33,6 +33,18 @@
   <packaging>jar</packaging>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-922 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/runners/direct-java/pom.xml
----------------------------------------------------------------------
diff --git a/runners/direct-java/pom.xml b/runners/direct-java/pom.xml
index 8983b1c..43cf3c0 100644
--- a/runners/direct-java/pom.xml
+++ b/runners/direct-java/pom.xml
@@ -40,6 +40,19 @@
       </resource>
     </resources>
 
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-924 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/runners/flink/pom.xml
----------------------------------------------------------------------
diff --git a/runners/flink/pom.xml b/runners/flink/pom.xml
index e012c4b..1b73922 100644
--- a/runners/flink/pom.xml
+++ b/runners/flink/pom.xml
@@ -95,6 +95,15 @@
             </execution>
           </executions>
         </plugin>
+
+        <!-- BEAM-931 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
       </plugins>
     </pluginManagement>
 

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/runners/google-cloud-dataflow-java/pom.xml
----------------------------------------------------------------------
diff --git a/runners/google-cloud-dataflow-java/pom.xml b/runners/google-cloud-dataflow-java/pom.xml
index a5ffe0e..59b1465 100644
--- a/runners/google-cloud-dataflow-java/pom.xml
+++ b/runners/google-cloud-dataflow-java/pom.xml
@@ -45,6 +45,19 @@
       </resource>
     </resources>
 
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-925 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/runners/spark/pom.xml
----------------------------------------------------------------------
diff --git a/runners/spark/pom.xml b/runners/spark/pom.xml
index 5e94848..1e4a720 100644
--- a/runners/spark/pom.xml
+++ b/runners/spark/pom.xml
@@ -318,6 +318,15 @@
   <build>
     <pluginManagement>
       <plugins>
+        <!-- BEAM-931 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-surefire-plugin</artifactId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
index 50c5ae9..f30825f 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
@@ -1840,8 +1840,8 @@ public class BigQueryIO {
         return PDone.in(input.getPipeline());
       }
 
-      private class WriteBundles extends DoFn<TableRow, KV<String, Long>> {
-        private TableRowWriter writer = null;
+      private static class WriteBundles extends DoFn<TableRow, KV<String, Long>> {
+        private transient TableRowWriter writer = null;
         private final String tempFilePrefix;
 
         WriteBundles(String tempFilePrefix) {

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/sdks/java/io/jms/pom.xml
----------------------------------------------------------------------
diff --git a/sdks/java/io/jms/pom.xml b/sdks/java/io/jms/pom.xml
index 7063ce9..40bc219 100644
--- a/sdks/java/io/jms/pom.xml
+++ b/sdks/java/io/jms/pom.xml
@@ -37,6 +37,19 @@
   </properties>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-927 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/sdks/java/io/kafka/pom.xml
----------------------------------------------------------------------
diff --git a/sdks/java/io/kafka/pom.xml b/sdks/java/io/kafka/pom.xml
index 1ad31aa..69329a4 100644
--- a/sdks/java/io/kafka/pom.xml
+++ b/sdks/java/io/kafka/pom.xml
@@ -30,6 +30,19 @@
   <description>Library to read Kafka topics.</description>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-928 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/sdks/java/io/kinesis/pom.xml
----------------------------------------------------------------------
diff --git a/sdks/java/io/kinesis/pom.xml b/sdks/java/io/kinesis/pom.xml
index f874c21..e0b57db 100644
--- a/sdks/java/io/kinesis/pom.xml
+++ b/sdks/java/io/kinesis/pom.xml
@@ -30,6 +30,19 @@
   <description>Library to read Kinesis streams.</description>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-929 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/sdks/java/io/mongodb/pom.xml
----------------------------------------------------------------------
diff --git a/sdks/java/io/mongodb/pom.xml b/sdks/java/io/mongodb/pom.xml
index 4b100a9..17dc6e7 100644
--- a/sdks/java/io/mongodb/pom.xml
+++ b/sdks/java/io/mongodb/pom.xml
@@ -31,6 +31,19 @@
   <description>IO to read and write on MongoDB.</description>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-930 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/e1291eea/sdks/java/microbenchmarks/pom.xml
----------------------------------------------------------------------
diff --git a/sdks/java/microbenchmarks/pom.xml b/sdks/java/microbenchmarks/pom.xml
index c95309c..06bc4df 100644
--- a/sdks/java/microbenchmarks/pom.xml
+++ b/sdks/java/microbenchmarks/pom.xml
@@ -32,6 +32,19 @@
   <packaging>jar</packaging>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <!-- BEAM-926 -->
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <configuration>
+            <skip>true</skip>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>


[3/3] incubator-beam git commit: Closes #1295

Posted by dh...@apache.org.
Closes #1295


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/b5f84735
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/b5f84735
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/b5f84735

Branch: refs/heads/master
Commit: b5f847355f2961b992abc3f8b4df71f0d96bb025
Parents: 1102455 e1291ee
Author: Dan Halperin <dh...@google.com>
Authored: Mon Nov 7 11:40:38 2016 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Mon Nov 7 11:40:38 2016 -0800

----------------------------------------------------------------------
 examples/java/pom.xml                                  | 13 +++++++++++++
 examples/java8/pom.xml                                 | 13 +++++++++++++
 examples/pom.xml                                       |  5 +++++
 runners/core-java/pom.xml                              | 12 ++++++++++++
 runners/direct-java/pom.xml                            | 13 +++++++++++++
 runners/flink/pom.xml                                  |  9 +++++++++
 runners/google-cloud-dataflow-java/pom.xml             | 13 +++++++++++++
 runners/pom.xml                                        |  5 +++++
 runners/spark/pom.xml                                  |  9 +++++++++
 sdks/java/core/pom.xml                                 |  5 -----
 .../apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java    |  4 ++--
 sdks/java/io/jms/pom.xml                               | 13 +++++++++++++
 sdks/java/io/kafka/pom.xml                             | 13 +++++++++++++
 sdks/java/io/kinesis/pom.xml                           | 13 +++++++++++++
 sdks/java/io/mongodb/pom.xml                           | 13 +++++++++++++
 sdks/java/microbenchmarks/pom.xml                      | 13 +++++++++++++
 sdks/pom.xml                                           |  5 +++++
 17 files changed, 164 insertions(+), 7 deletions(-)
----------------------------------------------------------------------



[2/3] incubator-beam git commit: move findbugs execution to release profile, enable in all modules

Posted by dh...@apache.org.
move findbugs execution to release profile, enable in all modules


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/fae52a3f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/fae52a3f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/fae52a3f

Branch: refs/heads/master
Commit: fae52a3f8f4963524c7883450aa740aefaf4a9c6
Parents: 1102455
Author: Dan Halperin <dh...@google.com>
Authored: Mon Nov 7 08:50:07 2016 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Mon Nov 7 10:43:11 2016 -0800

----------------------------------------------------------------------
 examples/pom.xml       | 5 +++++
 runners/pom.xml        | 5 +++++
 sdks/java/core/pom.xml | 5 -----
 sdks/pom.xml           | 5 +++++
 4 files changed, 15 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/fae52a3f/examples/pom.xml
----------------------------------------------------------------------
diff --git a/examples/pom.xml b/examples/pom.xml
index c6f9cb3..eb42861 100644
--- a/examples/pom.xml
+++ b/examples/pom.xml
@@ -54,6 +54,11 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
           </plugin>
+
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+          </plugin>
         </plugins>
       </build>
     </profile>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/fae52a3f/runners/pom.xml
----------------------------------------------------------------------
diff --git a/runners/pom.xml b/runners/pom.xml
index 9c821cc..8084d0b 100644
--- a/runners/pom.xml
+++ b/runners/pom.xml
@@ -49,6 +49,11 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
           </plugin>
+
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+          </plugin>
         </plugins>
       </build>
     </profile>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/fae52a3f/sdks/java/core/pom.xml
----------------------------------------------------------------------
diff --git a/sdks/java/core/pom.xml b/sdks/java/core/pom.xml
index 7906afb..77a3309 100644
--- a/sdks/java/core/pom.xml
+++ b/sdks/java/core/pom.xml
@@ -147,11 +147,6 @@
         </executions>
       </plugin>
 
-      <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>findbugs-maven-plugin</artifactId>
-      </plugin>
-
       <!-- Coverage analysis for unit tests. -->
       <plugin>
         <groupId>org.jacoco</groupId>

http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/fae52a3f/sdks/pom.xml
----------------------------------------------------------------------
diff --git a/sdks/pom.xml b/sdks/pom.xml
index 6347fe1..29ccd37 100644
--- a/sdks/pom.xml
+++ b/sdks/pom.xml
@@ -45,6 +45,11 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
           </plugin>
+
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+          </plugin>
         </plugins>
       </build>
     </profile>