You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/12/16 22:24:37 UTC

[Bug 55893] New: Split AccessLogValve and extract the formatting logic in an AbstractAccessLogValve

https://issues.apache.org/bugzilla/show_bug.cgi?id=55893

            Bug ID: 55893
           Summary: Split AccessLogValve and extract the formatting logic
                    in an AbstractAccessLogValve
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
                OS: Mac OS X 10.4
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: cleclerc@apache.org

Created attachment 31120
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31120&action=edit
Patch file

Split AccessLogValve in an AbstractAccessLogValve with the formatting logic and
an AccessLogValve with the logic to write logs into files.

This split will ease alternate implementations of access logs valves. For
example, a valve that would output access logs to a Syslog server.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55893] Split AccessLogValve and extract the formatting logic in an AbstractAccessLogValve

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55893

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
The proposed patch does not contain the new AbstractAccessLogValve class.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55893] Split AccessLogValve and extract the formatting logic in an AbstractAccessLogValve

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55893

Cyrille Le Clerc <cl...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31120|0                           |1
        is obsolete|                            |
                 CC|                            |cleclerc@apache.org

--- Comment #2 from Cyrille Le Clerc <cl...@apache.org> ---
Created attachment 31196
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31196&action=edit
Fixed patch with the forgotten AbstractAccessLogValve.java

Sorry for the mistake

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55893] Split AccessLogValve and extract the formatting logic in an AbstractAccessLogValve

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55893

--- Comment #5 from Mark Thomas <ma...@apache.org> ---
New features are being added to 7.0.x (e.g. JSR356 support). When deciding
whether to back-port a number of factors are considered:
- the size of the change
- the impact on the existing API
- the potential consequences if the patch introduces a regression

Given the size of the change and the potential consequences, I'd suggest
waiting for a 8.0.x release or two to make sure it hasn't broken anything and
then request a back-port. The API impact should be zero so there should be no
issue there.

Feel free to re-open this issue and set the product to Tomcat 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55893] Split AccessLogValve and extract the formatting logic in an AbstractAccessLogValve

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55893

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Thanks. Patch applied and will be included in 8.0.0 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55893] Split AccessLogValve and extract the formatting logic in an AbstractAccessLogValve

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55893

--- Comment #4 from Cyrille Le Clerc <cl...@apache.org> ---
Thanks. 

Can I propose the same patch for tomcat 7.X branch or are the changes of this
7.X branch limited to bug fixes?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org