[jira] [Commented] (THRIFT-4233) Make THsHaServer.invoker available (get method only) in inherited classes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061081#comment-16061081 ] 

ASF GitHub Bot commented on THRIFT-4233:
----------------------------------------

GitHub user dmvolod opened a pull request:

    https://github.com/apache/thrift/pull/1294

    THRIFT-4233 Make THsHaServer.invoker available (get method only) in inherited classes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dmvolod/thrift THRIFT-4233

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1294
    
----
commit 3d97c860c2c8aa7e6c5013edc1456cf8706ae654
Author: Dmitry Volodin <dm...@gmail.com>
Date:   2017-06-23T14:57:40Z

    THRIFT-4233 Make THsHaServer.invoker available (get method only) in
    inherited classes

----


> Make THsHaServer.invoker available (get method only) in inherited classes
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4233
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4233
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.10.0
>            Reporter: Dmitry Volodin
>
> In some cases (for example in Apache Camel component for Thrift) there is a requirement, when it is necessary not only to transfer executorService from the external system through the Args in THsHaServer , but to organize control them from outside. In this case, it's possible to create a class which is inherited from THsHaServer, but not possible to access invoker in overloaded gracefullyShutdownInvokerPool(). As workaround the TNonblockingServer must be extended but requires to create several methods from scratch.
> It's necessary to add code below to THsHaServer
> {code:java}
> protected ExecutorService getInvoker() {
>   return invoker;
> }
> {code}
> I'm ready to add this code as PR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)