You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Volodymyr Sobotovich (JIRA)" <ji...@apache.org> on 2007/10/31 09:02:50 UTC
[jira] Created: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
DownloadLink fix that encodes non-ASCII file names properly
-----------------------------------------------------------
Key: WICKET-1115
URL: https://issues.apache.org/jira/browse/WICKET-1115
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.2.6
Environment: Internet Explorer 6, Firefox 2.0.0.8
Reporter: Volodymyr Sobotovich
When users tries to download file with name consisting of non-ASCII characters browsers don't display its name correctly in download dialog box. To fix the problem the proper encoding must be applied to file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
This fix works IE6 and FF2. When I tested it in IE7 a discovered that few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Volodymyr Sobotovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Volodymyr Sobotovich updated WICKET-1115:
-----------------------------------------
Description:
When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
was:
When user tries to download file with name consisting of non-ASCII characters browsers don't display its name correctly in download dialog box. To fix the problem the proper encoding must be applied to file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
This fix works IE6 and FF2. When I tested it in IE7 a discovered that few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more:)
Minor spelling fixes
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1115.
-----------------------------------
Resolution: Fixed
Assignee: Igor Vaynberg (was: Timo Rantalaiho)
we now urlencode the filename which should fix any problems
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1115:
---------------------------------------
Fix Version/s: (was: 1.4-M1)
1.4-M2
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Fix For: 1.4-M2
>
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Volodymyr Sobotovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Volodymyr Sobotovich updated WICKET-1115:
-----------------------------------------
Attachment: DownloadLink.java
Proposed patch to DownloadLink.java
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Attachments: DownloadLink.java
>
>
> When users tries to download file with name consisting of non-ASCII characters browsers don't display its name correctly in download dialog box. To fix the problem the proper encoding must be applied to file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1115:
---------------------------------------
Fix Version/s: (was: 1.4-M2)
1.4-M3
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Fix For: 1.4-M3
>
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Volodymyr Sobotovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Volodymyr Sobotovich updated WICKET-1115:
-----------------------------------------
Description:
When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
was:
When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
Minor spelling fixes
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1115:
-------------------------------------
Fix Version/s: (was: 1.4-M3)
1.4-M4
Moved to next milestone release.
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Fix For: 1.4-M4
>
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho reassigned WICKET-1115:
---------------------------------------
Assignee: Timo Rantalaiho
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Assignee: Timo Rantalaiho
> Fix For: 1.4-M4
>
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1115:
------------------------------------
Fix Version/s: 1.4.0-alpha
Did you patch it already so that also it works fine in IE7?
Also can you make a real patch so not the file itself but a svn-patch? Because the download file is already changed so then the merging is much easier.
i don't like that we need to include commons-codec just for this. So if you make a patch please copy them from that lib and include them into a wicket package.
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Fix For: 1.4.0-alpha
>
> Attachments: DownloadLink.java
>
>
> When a user tries to download a file with its name consisting of non-ASCII characters browsers don't display the name correctly in download dialog box. To fix the problem the proper encoding must be applied to the file name. IE expects URL-encoding to be used and Firefox Q- or Base64. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that a few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more a little:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1115) DownloadLink fix that encodes
non-ASCII file names properly
Posted by "Volodymyr Sobotovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Volodymyr Sobotovich updated WICKET-1115:
-----------------------------------------
Description:
When user tries to download file with name consisting of non-ASCII characters browsers don't display its name correctly in download dialog box. To fix the problem the proper encoding must be applied to file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
This fix works IE6 and FF2. When I tested it in IE7 a discovered that few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more:)
was:
When users tries to download file with name consisting of non-ASCII characters browsers don't display its name correctly in download dialog box. To fix the problem the proper encoding must be applied to file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
This fix works IE6 and FF2. When I tested it in IE7 a discovered that few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more:)
> DownloadLink fix that encodes non-ASCII file names properly
> -----------------------------------------------------------
>
> Key: WICKET-1115
> URL: https://issues.apache.org/jira/browse/WICKET-1115
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.2.6
> Environment: Internet Explorer 6, Firefox 2.0.0.8
> Reporter: Volodymyr Sobotovich
> Attachments: DownloadLink.java
>
>
> When user tries to download file with name consisting of non-ASCII characters browsers don't display its name correctly in download dialog box. To fix the problem the proper encoding must be applied to file name. IE expects URL-encoding to be used and Firefox Q- or Base4. That's why it's necessary to detect user's browser type and use the appropriate codec. Codecs were borrowed from commons-codec library.
> This fix works IE6 and FF2. When I tested it in IE7 a discovered that few starting characters are displayed incorrectly. I mean that IE7 must use some variation of URL encoding and that's why this patch must be patched more:)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.