You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Stephen McConnell <mc...@apache.org> on 2004/09/03 20:26:34 UTC
[patch] recent magic updates
The following patch corrects a change introduced a couple of days ago to
Magic's Context class. The old change introduced the parameterization
of unit test class filters but in the process changed the included
pattern from only *UnitTest.java to *Test.java. That change is breaking
builds in logkit, meta, and repository.
The following patch reverts the pattern to the original form which will
restore normal build behavior.
Stephen.
Index: src/main/org/apache/avalon/tools/model/Context.java
===================================================================
--- src/main/org/apache/avalon/tools/model/Context.java (revision 37479)
+++ src/main/org/apache/avalon/tools/model/Context.java (working copy)
@@ -146,7 +146,7 @@
/**
* default value
*/
- public static final String TEST_INCLUDES_VALUE =
"**/*TestCase.java, **/*Test.java";
+ public static final String TEST_INCLUDES_VALUE =
"**/*TestCase.java";
/**
* the key for the exclude pattern for test cases
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
RE: [patch] recent magic updates
Posted by Stephen McConnell <mc...@apache.org>.
> -----Original Message-----
> From: Niclas Hedhman [mailto:niclas@hedhman.org]
> Sent: 04 September 2004 12:58
> To: Avalon Developers List
> Subject: Re: [patch] recent magic updates
>
> From: "Stephen McConnell" <mc...@apache.org>
>
> > > From: Niclas Hedhman [mailto:niclas@hedhman.org]
>
> > > Why is that breaking LogKit??
> > >
> > > The change was made as it is fairly common naming convention with
> > > *Test.java, as it has been recommended from the Junit camp.
> > >
> > > Please clarify. I am unable to build from this tractor, so I can't
> > check
> > > myself.
> >
> > LogKit contains a file that end with "Test.java" but its not a
UnitTest
> > and that's what's breaking the build. See message titled [logkit]
> > DatagramTest for the explanation of why its failing and the change
> > needed.
>
> But change of class name has been done instead, so that would be
enough,
> right?
Yep.
Steve.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
Re: [patch] recent magic updates
Posted by Niclas Hedhman <ni...@hedhman.org>.
From: "Stephen McConnell" <mc...@apache.org>
> > From: Niclas Hedhman [mailto:niclas@hedhman.org]
> > Why is that breaking LogKit??
> >
> > The change was made as it is fairly common naming convention with
> > *Test.java, as it has been recommended from the Junit camp.
> >
> > Please clarify. I am unable to build from this tractor, so I can't
> check
> > myself.
>
> LogKit contains a file that end with "Test.java" but its not a UnitTest
> and that's what's breaking the build. See message titled [logkit]
> DatagramTest for the explanation of why its failing and the change
> needed.
But change of class name has been done instead, so that would be enough,
right?
Alternatively, one can make an exclude filter in the project.
Cheers
Niclas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
RE: [patch] recent magic updates
Posted by Stephen McConnell <mc...@apache.org>.
> -----Original Message-----
> From: Niclas Hedhman [mailto:niclas@hedhman.org]
> Sent: 04 September 2004 11:45
> To: Avalon Developers List
> Subject: Re: [patch] recent magic updates
>
> Why is that breaking LogKit??
>
> The change was made as it is fairly common naming convention with
> *Test.java, as it has been recommended from the Junit camp.
>
> Please clarify. I am unable to build from this tractor, so I can't
check
> myself.
LogKit contains a file that end with "Test.java" but its not a UnitTest
and that's what's breaking the build. See message titled [logkit]
DatagramTest for the explanation of why its failing and the change
needed.
Cheers, Steve.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org
Re: [patch] recent magic updates
Posted by Niclas Hedhman <ni...@hedhman.org>.
Why is that breaking LogKit??
The change was made as it is fairly common naming convention with
*Test.java, as it has been recommended from the Junit camp.
Please clarify. I am unable to build from this tractor, so I can't check
myself.
Cheers
Niclas
----- Original Message -----
From: "Stephen McConnell" <mc...@apache.org>
To: "Avalon Developers List" <de...@avalon.apache.org>
Sent: Friday, September 03, 2004 8:26 PM
Subject: [patch] recent magic updates
>
>
> The following patch corrects a change introduced a couple of days ago to
> Magic's Context class. The old change introduced the parameterization
> of unit test class filters but in the process changed the included
> pattern from only *UnitTest.java to *Test.java. That change is breaking
> builds in logkit, meta, and repository.
>
> The following patch reverts the pattern to the original form which will
> restore normal build behavior.
>
> Stephen.
>
>
>
> Index: src/main/org/apache/avalon/tools/model/Context.java
> ===================================================================
> --- src/main/org/apache/avalon/tools/model/Context.java (revision 37479)
> +++ src/main/org/apache/avalon/tools/model/Context.java (working copy)
> @@ -146,7 +146,7 @@
> /**
> * default value
> */
> - public static final String TEST_INCLUDES_VALUE =
> "**/*TestCase.java, **/*Test.java";
> + public static final String TEST_INCLUDES_VALUE =
> "**/*TestCase.java";
>
> /**
> * the key for the exclude pattern for test cases
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
> For additional commands, e-mail: dev-help@avalon.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org