You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Woonsan Ko (Created) (JIRA)" <je...@portals.apache.org> on 2011/10/05 16:45:34 UTC

[jira] [Created] (JS2-1268) File download (fileserver) pipeline is broken since 2.2.1

File download (fileserver) pipeline is broken since 2.2.1
---------------------------------------------------------

                 Key: JS2-1268
                 URL: https://issues.apache.org/jira/browse/JS2-1268
             Project: Jetspeed 2
          Issue Type: Bug
    Affects Versions: 2.2.1
            Reporter: Woonsan Ko


The fileserver pipeline seems to have been broken since 2.2.1. (I couldn't find a download link to 2.2.0.)
It works fine with 2.1.4 release when a pdf file is copied into /j2-admin/WEB-INF/_content/en/sample_pdf.pdf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] [Commented] (JS2-1268) File download (fileserver) pipeline is broken since 2.2.1

Posted by "Ate Douma (Commented) (JIRA)" <je...@portals.apache.org>.
    [ https://issues.apache.org/jira/browse/JS2-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121430#comment-13121430 ] 

Ate Douma commented on JS2-1268:
--------------------------------

Download link for 2.2.0 demo installer: http://archive.apache.org/dist/portals/jetspeed-2/binaries/jetspeed-installer-demo-2.2.0.jar
                
> File download (fileserver) pipeline is broken since 2.2.1
> ---------------------------------------------------------
>
>                 Key: JS2-1268
>                 URL: https://issues.apache.org/jira/browse/JS2-1268
>             Project: Jetspeed 2
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Woonsan Ko
>             Fix For: 2.2.3
>
>
> The fileserver pipeline seems to have been broken since 2.2.1. (I couldn't find a download link to 2.2.0.)
> It works fine with 2.1.4 release when a pdf file is copied into /j2-admin/WEB-INF/_content/en/sample_pdf.pdf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] [Commented] (JS2-1268) File download (fileserver) pipeline is broken since 2.2.1

Posted by "Ate Douma (Commented) (JIRA)" <je...@portals.apache.org>.
    [ https://issues.apache.org/jira/browse/JS2-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121434#comment-13121434 ] 

Ate Douma commented on JS2-1268:
--------------------------------

It worked fine in Jetspeed 2.2.0 too
                
> File download (fileserver) pipeline is broken since 2.2.1
> ---------------------------------------------------------
>
>                 Key: JS2-1268
>                 URL: https://issues.apache.org/jira/browse/JS2-1268
>             Project: Jetspeed 2
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Woonsan Ko
>             Fix For: 2.2.3
>
>
> The fileserver pipeline seems to have been broken since 2.2.1. (I couldn't find a download link to 2.2.0.)
> It works fine with 2.1.4 release when a pdf file is copied into /j2-admin/WEB-INF/_content/en/sample_pdf.pdf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] [Updated] (JS2-1268) File download (fileserver) pipeline is broken since 2.2.1

Posted by "Ate Douma (Updated) (JIRA)" <je...@portals.apache.org>.
     [ https://issues.apache.org/jira/browse/JS2-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma updated JS2-1268:
---------------------------

    Priority: Minor  (was: Major)

I looked into this and found the cause of it: this functionality was 'lost' during the introduction of the DynamicPage support, svn r891420, specifically the changes in o.a.j.profiler.rules.impl.PathSessionResolver.java

Now, it could be pretty easy to 'restore' this functionality, like for example with the following patch:

  Index: src/main/java/org/apache/jetspeed/aggregator/FileServerValve.java
  ===================================================================
  --- src/main/java/org/apache/jetspeed/aggregator/FileServerValve.java	(revision 1179114)
  +++ src/main/java/org/apache/jetspeed/aggregator/FileServerValve.java	(working copy)
  @@ -63,6 +63,7 @@
               {
                   request.setAttribute(PortalReservedParameters.PORTLET, portletName);
               }        
  +            request.setAttribute(PortalReservedParameters.PATH_ATTRIBUTE, request.getPath());
           }
           catch (Exception e)
           {

This will already work (tested locally).

However, the question is: do we really want to solve it like this and leave it at that?

I've some ideas about this and a possible easy alternative solution in mind, but which I first want to explore a bit further and come on this sometime later.

At any rate, I think this 'bug' really only is a minor issue, although a bit annoying as it currently isn't working for both the 2.2.1 and 2.2.2 releases.
I'm therefore lowering the priority of this issue to Minor until further notice.
                
> File download (fileserver) pipeline is broken since 2.2.1
> ---------------------------------------------------------
>
>                 Key: JS2-1268
>                 URL: https://issues.apache.org/jira/browse/JS2-1268
>             Project: Jetspeed 2
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Woonsan Ko
>            Priority: Minor
>             Fix For: 2.2.3
>
>
> The fileserver pipeline seems to have been broken since 2.2.1. (I couldn't find a download link to 2.2.0.)
> It works fine with 2.1.4 release when a pdf file is copied into /j2-admin/WEB-INF/_content/en/sample_pdf.pdf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] [Commented] (JS2-1268) File download (fileserver) pipeline is broken since 2.2.1

Posted by "Woonsan Ko (Commented) (JIRA)" <je...@portals.apache.org>.
    [ https://issues.apache.org/jira/browse/JS2-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121931#comment-13121931 ] 

Woonsan Ko commented on JS2-1268:
---------------------------------

Cool! Yes, this seems a minor issue now because there will be many alternatives. Thanks!
                
> File download (fileserver) pipeline is broken since 2.2.1
> ---------------------------------------------------------
>
>                 Key: JS2-1268
>                 URL: https://issues.apache.org/jira/browse/JS2-1268
>             Project: Jetspeed 2
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Woonsan Ko
>            Priority: Minor
>             Fix For: 2.2.3
>
>
> The fileserver pipeline seems to have been broken since 2.2.1. (I couldn't find a download link to 2.2.0.)
> It works fine with 2.1.4 release when a pdf file is copied into /j2-admin/WEB-INF/_content/en/sample_pdf.pdf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] [Updated] (JS2-1268) File download (fileserver) pipeline is broken since 2.2.1

Posted by "Woonsan Ko (Updated) (JIRA)" <je...@portals.apache.org>.
     [ https://issues.apache.org/jira/browse/JS2-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Woonsan Ko updated JS2-1268:
----------------------------

    Fix Version/s: 2.2.3
    
> File download (fileserver) pipeline is broken since 2.2.1
> ---------------------------------------------------------
>
>                 Key: JS2-1268
>                 URL: https://issues.apache.org/jira/browse/JS2-1268
>             Project: Jetspeed 2
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Woonsan Ko
>             Fix For: 2.2.3
>
>
> The fileserver pipeline seems to have been broken since 2.2.1. (I couldn't find a download link to 2.2.0.)
> It works fine with 2.1.4 release when a pdf file is copied into /j2-admin/WEB-INF/_content/en/sample_pdf.pdf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org