You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/12/11 16:19:20 UTC
[GitHub] nifi pull request #3214: NIFI-5890 Added a unit test that proves that 1.9 fi...
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/3214
NIFI-5890 Added a unit test that proves that 1.9 fixes a bug in the d…
…ate conversion behavior in 1.8.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MikeThomsen/nifi NIFI-5890
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3214
----
commit ef8bac12ba38d6eaeae6ccb45238c2046126a8d4
Author: Mike Thomsen <mi...@...>
Date: 2018-12-11T16:18:52Z
NIFI-5890 Added a unit test that proves that 1.9 fixes a bug in the date conversion behavior in 1.8.
----
---
[GitHub] nifi pull request #3214: NIFI-5890 Added a unit test that proves that 1.9 fi...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3214#discussion_r240980560
--- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java ---
@@ -404,7 +404,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
reason = itemNode.findPath("reason").asText();
}
errorReason = reason;
- logger.error("Failed to process {} due to {}, transferring to failure",
+ta logger.error("Failed to process {} due to {}, transferring to failure",
--- End diff --
Yeah, definitely not. Thanks!
---
[GitHub] nifi pull request #3214: NIFI-5890 Added a unit test that proves that 1.9 fi...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3214#discussion_r240856001
--- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java ---
@@ -404,7 +404,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
reason = itemNode.findPath("reason").asText();
}
errorReason = reason;
- logger.error("Failed to process {} due to {}, transferring to failure",
+ta logger.error("Failed to process {} due to {}, transferring to failure",
--- End diff --
I believe this change is not intentional.
---
[GitHub] nifi pull request #3214: NIFI-5890 Added a unit test that proves that 1.9 fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3214
---