You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/12/09 10:06:15 UTC

[GitHub] [incubator-hugegraph-computer] imbajin commented on a diff in pull request #218: chore: add apache-release.sh & prepare release

imbajin commented on code in PR #218:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/218#discussion_r1044286482


##########
computer-dist/scripts/apache-release.sh:
##########
@@ -21,8 +21,10 @@ GROUP="hugegraph"
 REPO="${GROUP}-computer"
 # release version (input by committer)
 RELEASE_VERSION=$1
+USERNAME=$2
+PASSWORD=$3
 # git release branch (check it carefully)
-GIT_BRANCH="release-${RELEASE_VERSION}"
+GIT_BRANCH="$(git branch --show-current)"

Review Comment:
   seems a little dangerous when upload with a wrong branch? or check the `branch-name` below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org