[GitHub] [beam] tvalentyn commented on a change in pull request #12384: Fix various issues in release instructions and scripts observed while preparing 2.23.0.

[GitBox <gi...@apache.org>]

tvalentyn commented on a change in pull request #12384:
URL: https://github.com/apache/beam/pull/12384#discussion_r461859314



##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -288,14 +288,15 @@ if [[ $confirmation = "y" ]]; then
   mkdir -p ${LOCAL_WEBSITE_REPO}
 
   echo "------------------Building Python Doc------------------------"
-  virtualenv ${LOCAL_PYTHON_VIRTUALENV}
-  source ${LOCAL_PYTHON_VIRTUALENV}/bin/activate
+  python3 -m venv "${LOCAL_PYTHON_VIRTUALENV}"

Review comment:
       The new apprach works starting from Py3 as venv became released as part of the standard library and is now documented in Python docs: https://docs.python.org/3/library/venv.html. Old approach also works if virtualenv is installed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org