You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/01 17:13:14 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request #4793: NIFI-8186 Excluded bcprov-ext-jdk15on from spring-security-saml2-core
exceptionfactory opened a new pull request #4793:
URL: https://github.com/apache/nifi/pull/4793
#### Description of PR
NIFI-8186 Updates the `spring-security-saml2-core` dependency management definition to exclude the bcprov-ext-jdk15on library. The `spring-security-saml2-core` depends on `com.narupley:not-going-to-be-commons-ssl` that in turn depends on `bcprov-ext-jdk15on` version 1.60. The current version of NiFi depends on the standard `bcprov-jdk15on` library version 1.68 so inclusion of the different version of the extension library could cause unexpected problems at runtime. The Spring Security SAML2 library does not appear to needed the obscure algorithm classes included in the `bcprov-ext-jdk15on` library, so the library should be excluded from bundled dependencies.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4793: NIFI-8186 Excluded bcprov-ext-jdk15on from spring-security-saml2-core
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4793:
URL: https://github.com/apache/nifi/pull/4793#issuecomment-771058705
Looks good, did a quick test of authenticating with SAML and worked as expected, going to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende merged pull request #4793: NIFI-8186 Excluded bcprov-ext-jdk15on from spring-security-saml2-core
Posted by GitBox <gi...@apache.org>.
bbende merged pull request #4793:
URL: https://github.com/apache/nifi/pull/4793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org