You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/07/11 05:47:52 UTC

[GitHub] [openwhisk] upgle opened a new pull request, #5276: Bumping to gradle 6

upgle opened a new pull request, #5276:
URL: https://github.com/apache/openwhisk/pull/5276

   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   - Gradle 5 uses [Deprecated Typesafe Zinc compiler](https://github.com/typesafehub/zinc), and gradle 6.x supports SBT Zinc. (Versions 1.2.0 and above.)
   - Upgrade the version of akka-grpc-gradle-plugin for compatibility issue with gradle 6.
   
   
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [x] General tooling
   
   
   ## Types of changes
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r928235385


##########
core/standalone/build.gradle:
##########
@@ -157,17 +157,19 @@ gitProperties {
 install.dependsOn(bootJar)
 
 dependencies {
-    compile "org.scala-lang:scala-library:${gradle.scala.version}"
-    compile project(':core:controller')
-    compile project(':tools:admin')
-    compile "org.rogach:scallop_${gradle.scala.depVersion}:3.3.2"
-
-    compile "io.github.embeddedkafka:embedded-kafka_${gradle.scala.depVersion}:2.4.0"
-    compile "org.scala-lang:scala-reflect:${gradle.scala.version}"
-    compile "ch.megard:akka-http-cors_${gradle.scala.depVersion}:0.4.2"
-
-    testCompile "junit:junit:4.11"
-    testCompile "org.scalatest:scalatest_${gradle.scala.depVersion}:3.0.8"
+    implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+    implementation project(':common:scala')

Review Comment:
   Yes, The `compile` keyword is deprecated. you need to use the `implementation`.
   
   > The usage of the compile and runtime configurations in the Java ecosystem plugins has been discouraged since [Gradle 3.4](https://docs.gradle.org/3.4/release-notes.html#the-java-library-plugin).
   
   https://docs.gradle.org/current/userguide/upgrading_version_5.html#dependencies_should_no_longer_be_declared_using_the_compile_and_runtime_configurations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r931709506


##########
core/invoker/build.gradle:
##########
@@ -32,17 +32,16 @@ ext.coverageDirs = [
     "${buildDir}/classes/scala/scoverage",
     "${project(':common:scala').buildDir.absolutePath}/classes/scala/scoverage"
 ]
-distDockerCoverage.dependsOn ':common:scala:scoverageClasses', 'scoverageClasses'

Review Comment:
   @style95 It's solved by upgrading the version of the scoverage gradle plugin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r926190664


##########
core/standalone/build.gradle:
##########
@@ -157,17 +157,19 @@ gitProperties {
 install.dependsOn(bootJar)
 
 dependencies {
-    compile "org.scala-lang:scala-library:${gradle.scala.version}"
-    compile project(':core:controller')
-    compile project(':tools:admin')
-    compile "org.rogach:scallop_${gradle.scala.depVersion}:3.3.2"
-
-    compile "io.github.embeddedkafka:embedded-kafka_${gradle.scala.depVersion}:2.4.0"
-    compile "org.scala-lang:scala-reflect:${gradle.scala.version}"
-    compile "ch.megard:akka-http-cors_${gradle.scala.depVersion}:0.4.2"
-
-    testCompile "junit:junit:4.11"
-    testCompile "org.scalatest:scalatest_${gradle.scala.depVersion}:3.0.8"
+    implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+    implementation project(':common:scala')

Review Comment:
   So we need to explicitly add all dependencies with `implementation`?



##########
core/invoker/build.gradle:
##########
@@ -32,17 +32,16 @@ ext.coverageDirs = [
     "${buildDir}/classes/scala/scoverage",
     "${project(':common:scala').buildDir.absolutePath}/classes/scala/scoverage"
 ]
-distDockerCoverage.dependsOn ':common:scala:scoverageClasses', 'scoverageClasses'

Review Comment:
   How is this `dependsOn` handled now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r918466750


##########
core/scheduler/build.gradle:
##########
@@ -44,7 +44,7 @@ buildscript {
     dependencies {
         // see https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle
         // for the currently latest version.
-        classpath 'gradle.plugin.com.lightbend.akka.grpc:akka-grpc-gradle-plugin:0.7.2'
+        classpath 'com.lightbend.akka.grpc:akka-grpc-gradle-plugin:1.0.0'

Review Comment:
   No, this is for resolving compatibility issue with gradle 6.
   This PR is for gradle version upgrade only and does not consider any other issues.
   
   ----
   
   
   The problem you mentioned seems to be fixed in the akka-grpc 2.1.0 version.
   I tried to upgrade the version, but the build does not work due to a dependency problem.
   
   It would be better to deal with other PR.
   
   https://github.com/akka/akka-grpc/releases/tag/v2.1.0
   https://github.com/akka/akka-grpc/pull/1363



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r918466750


##########
core/scheduler/build.gradle:
##########
@@ -44,7 +44,7 @@ buildscript {
     dependencies {
         // see https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle
         // for the currently latest version.
-        classpath 'gradle.plugin.com.lightbend.akka.grpc:akka-grpc-gradle-plugin:0.7.2'
+        classpath 'com.lightbend.akka.grpc:akka-grpc-gradle-plugin:1.0.0'

Review Comment:
   No, this is for resolving compatibility issue with gradle 6.
   This PR is for gradle version upgrade only and does not consider any other issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r928235114


##########
core/invoker/build.gradle:
##########
@@ -32,17 +32,16 @@ ext.coverageDirs = [
     "${buildDir}/classes/scala/scoverage",
     "${project(':common:scala').buildDir.absolutePath}/classes/scala/scoverage"
 ]
-distDockerCoverage.dependsOn ':common:scala:scoverageClasses', 'scoverageClasses'

Review Comment:
   I'm currently looking for a way to recover this deleted line. gradle6 doesn't work because of this line.
   
   There is a compatibility issue where compiled classes are deleted after running the distDockerCoverage task. (It is difficult to find the cause.)
   
   This line is related to this change: https://github.com/apache/openwhisk/pull/3685
   It doesn't seem like a common usage. I'm spending quite a bit of time fixing this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r928345009


##########
core/standalone/build.gradle:
##########
@@ -157,17 +157,19 @@ gitProperties {
 install.dependsOn(bootJar)
 
 dependencies {
-    compile "org.scala-lang:scala-library:${gradle.scala.version}"
-    compile project(':core:controller')
-    compile project(':tools:admin')
-    compile "org.rogach:scallop_${gradle.scala.depVersion}:3.3.2"
-
-    compile "io.github.embeddedkafka:embedded-kafka_${gradle.scala.depVersion}:2.4.0"
-    compile "org.scala-lang:scala-reflect:${gradle.scala.version}"
-    compile "ch.megard:akka-http-cors_${gradle.scala.depVersion}:0.4.2"
-
-    testCompile "junit:junit:4.11"
-    testCompile "org.scalatest:scalatest_${gradle.scala.depVersion}:3.0.8"
+    implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+    implementation project(':common:scala')

Review Comment:
   I meant that we previously didn't need to import `common` but now we have to import `common`(and all dependencies) explicitly as we are using `implementation`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#issuecomment-1197660112

   Fixed all dependency issues. No code changes and all test code passed, so I'll merge it soon.
   
   > In my development environment (Intellij June 21, 2022), there is an issue that a full build is made even if one line of test code is modified. The new zinc compiler with gradle 6 doesn't have that problem, and this PR improves productivity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] codecov-commenter commented on pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#issuecomment-1188670291

   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#5276](https://codecov.io/gh/apache/openwhisk/pull/5276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1094ac3) into [master](https://codecov.io/gh/apache/openwhisk/commit/88435790cbed79db3f887c1918599cb9dead2590?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8843579) will **decrease** coverage by `17.11%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #5276       +/-   ##
   ===========================================
   - Coverage   80.09%   62.97%   -17.12%     
   ===========================================
     Files         238      238               
     Lines       14080    14161       +81     
     Branches      576      614       +38     
   ===========================================
   - Hits        11277     8918     -2359     
   - Misses       2803     5243     +2440     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/5276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...che/openwhisk/core/loadBalancer/LeanBalancer.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xlYW5CYWxhbmNlci5zY2FsYQ==) | `0.00% <ø> (ø)` | |
   | [...che/openwhisk/core/invoker/LogStoreCollector.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9Mb2dTdG9yZUNvbGxlY3Rvci5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...nwhisk/core/scheduler/queue/ContainerCounter.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvcXVldWUvQ29udGFpbmVyQ291bnRlci5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hisk/core/scheduler/message/ContainerMessage.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvbWVzc2FnZS9Db250YWluZXJNZXNzYWdlLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...core/scheduler/queue/SchedulingDecisionMaker.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvcXVldWUvU2NoZWR1bGluZ0RlY2lzaW9uTWFrZXIuc2NhbGE=) | `0.00% <0.00%> (-98.80%)` | :arrow_down: |
   | [...sk/core/scheduler/container/ContainerManager.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvY29udGFpbmVyL0NvbnRhaW5lck1hbmFnZXIuc2NhbGE=) | `0.00% <0.00%> (-96.90%)` | :arrow_down: |
   | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0.00% <0.00%> (-95.85%)` | :arrow_down: |
   | ... and [70 more](https://codecov.io/gh/apache/openwhisk/pull/5276/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/5276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8843579...1094ac3](https://codecov.io/gh/apache/openwhisk/pull/5276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r918466750


##########
core/scheduler/build.gradle:
##########
@@ -44,7 +44,7 @@ buildscript {
     dependencies {
         // see https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle
         // for the currently latest version.
-        classpath 'gradle.plugin.com.lightbend.akka.grpc:akka-grpc-gradle-plugin:0.7.2'
+        classpath 'com.lightbend.akka.grpc:akka-grpc-gradle-plugin:1.0.0'

Review Comment:
   No, this is for resolving compatibility issue with gradle 6.
   This PR is for gradle version upgrade only and does not consider any other issues.
   
   ----
   
   
   The problem you mentioned seems to be fixed in the akka-grpc 2.1.0 version.
   I tried to upgrade the version, but the build does not work due to a dependency problem.
   
   It would be better to deal with other issues.
   
   https://github.com/akka/akka-grpc/releases/tag/v2.1.0
   https://github.com/akka/akka-grpc/pull/1363



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r928351370


##########
core/standalone/build.gradle:
##########
@@ -157,17 +157,19 @@ gitProperties {
 install.dependsOn(bootJar)
 
 dependencies {
-    compile "org.scala-lang:scala-library:${gradle.scala.version}"
-    compile project(':core:controller')
-    compile project(':tools:admin')
-    compile "org.rogach:scallop_${gradle.scala.depVersion}:3.3.2"
-
-    compile "io.github.embeddedkafka:embedded-kafka_${gradle.scala.depVersion}:2.4.0"
-    compile "org.scala-lang:scala-reflect:${gradle.scala.version}"
-    compile "ch.megard:akka-http-cors_${gradle.scala.depVersion}:0.4.2"
-
-    testCompile "junit:junit:4.11"
-    testCompile "org.scalatest:scalatest_${gradle.scala.depVersion}:3.0.8"
+    implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+    implementation project(':common:scala')

Review Comment:
   I don't know how it worked before. I remember that it was added because a dependency problem occurred.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r918452449


##########
core/scheduler/build.gradle:
##########
@@ -44,7 +44,7 @@ buildscript {
     dependencies {
         // see https://plugins.gradle.org/plugin/com.lightbend.akka.grpc.gradle
         // for the currently latest version.
-        classpath 'gradle.plugin.com.lightbend.akka.grpc:akka-grpc-gradle-plugin:0.7.2'
+        classpath 'com.lightbend.akka.grpc:akka-grpc-gradle-plugin:1.0.0'

Review Comment:
   Does this handle the annoying akka-grpc plugin logs issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] upgle merged pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
upgle merged PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] rabbah commented on pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
rabbah commented on PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#issuecomment-1187583892

   🎉 this is great thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5276: Bumping to gradle 6

Posted by GitBox <gi...@apache.org>.
style95 commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r928345163


##########
core/invoker/build.gradle:
##########
@@ -32,17 +32,16 @@ ext.coverageDirs = [
     "${buildDir}/classes/scala/scoverage",
     "${project(':common:scala').buildDir.absolutePath}/classes/scala/scoverage"
 ]
-distDockerCoverage.dependsOn ':common:scala:scoverageClasses', 'scoverageClasses'

Review Comment:
   Can we just migrate to the way that is used with Gradle6 rather than fixing the issue as is?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org