[GitHub] [skywalking] BFergerson edited a comment on issue #4609: vert.x plugin can not boot

[GitBox <gi...@apache.org>]

BFergerson edited a comment on issue #4609: vert.x plugin can not boot 
URL: https://github.com/apache/skywalking/issues/4609#issuecomment-609770532
 
 
   I will work on moving the Vert.x scenarios and adding support for Vert.x 3.8.x this week.
   
   @zohar-soul, I don't think any of the plugins have documentation. What @wu-sheng said above is the best case for figuring out how the plugin works. The documentation for Apache SkyWalking is pretty good and for me to explain how the plugin works would mean to literally re-iterate what's already documented in this project, given that it relies heavily on this project itself to work. The code for getting Vert.x to work with Apache SkyWalking is < 1000 LOC so the plugin support itself is not the complicated part. See: [Plugin Development Guide](https://github.com/apache/skywalking/blob/master/docs/en/guides/Java-Plugin-Development-Guide.md)
   
   As for the deprecated methods, you should understand that the Vert.x plugin strives to work with the largest range of versions possible so there may be mentions of deprecated (and even removed) functionality without the plugin itself. With that being said, the code you posted is not actually present in the plugin but rather present in the plugin's test code. Changing that test code wouldn't fix your issue but actually might break the ability to test versions prior to 3.6.x. I'll try to remove it but I imagine I'll end up needing to write an additional test instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services