You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/21 05:16:19 UTC
Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-9014
https://issues.apache.org/jira/browse/MESOS-9014
Repository: mesos
Description
-------
This patch fixes the flaky test by explicitly killing the
task before test tear-down, avoiding the race condition
between scheduler tear-down and scheduler getting/acknowledging
status update.
Diffs
-----
src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
Diff: https://reviews.apache.org/r/67681/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/#review205163
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67681]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 21, 2018, 1:16 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67681/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 1:16 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9014
> https://issues.apache.org/jira/browse/MESOS-9014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the flaky test by explicitly killing the
> task before test tear-down, avoiding the race condition
> between scheduler tear-down and scheduler getting/acknowledging
> status update.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67681/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/#review205463
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On June 21, 2018, 6:33 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67681/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 6:33 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9014
> https://issues.apache.org/jira/browse/MESOS-9014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the flaky test by explicitly killing the
> task before test tear-down, avoiding the race condition
> between scheduler tear-down and scheduler getting/acknowledging
> status update.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67681/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/#review205208
-----------------------------------------------------------
PASS: Mesos patch 67681 was successfully built and tested.
Reviews applied: `['67681']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67681
- Mesos Reviewbot Windows
On June 21, 2018, 6:33 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67681/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 6:33 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9014
> https://issues.apache.org/jira/browse/MESOS-9014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the flaky test by explicitly killing the
> task before test tear-down, avoiding the race condition
> between scheduler tear-down and scheduler getting/acknowledging
> status update.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67681/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/#review205225
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67681]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 21, 2018, 6:33 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67681/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 6:33 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9014
> https://issues.apache.org/jira/browse/MESOS-9014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the flaky test by explicitly killing the
> task before test tear-down, avoiding the race condition
> between scheduler tear-down and scheduler getting/acknowledging
> status update.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67681/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/
-----------------------------------------------------------
(Updated June 21, 2018, 11:33 a.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed Greg's comment. Removed the last scheduler ack to avoid racing.
Bugs: MESOS-9014
https://issues.apache.org/jira/browse/MESOS-9014
Repository: mesos
Description
-------
This patch fixes the flaky test by explicitly killing the
task before test tear-down, avoiding the race condition
between scheduler tear-down and scheduler getting/acknowledging
status update.
Diffs (updated)
-----
src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
Diff: https://reviews.apache.org/r/67681/diff/2/
Changes: https://reviews.apache.org/r/67681/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/#review205157
-----------------------------------------------------------
PASS: Mesos patch 67681 was successfully built and tested.
Reviews applied: `['67681']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67681
- Mesos Reviewbot Windows
On June 21, 2018, 5:16 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67681/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 5:16 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9014
> https://issues.apache.org/jira/browse/MESOS-9014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the flaky test by explicitly killing the
> task before test tear-down, avoiding the race condition
> between scheduler tear-down and scheduler getting/acknowledging
> status update.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67681/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67681: Fixed flaky test
`MasterAPITest.SubscribersReceiveHealthUpdates`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/#review205188
-----------------------------------------------------------
src/tests/api_tests.cpp
Lines 2514 (patched)
<https://reviews.apache.org/r/67681/#comment288124>
It seems like the sending of this ACK may race with test teardown now?
- Greg Mann
On June 21, 2018, 5:16 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67681/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 5:16 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9014
> https://issues.apache.org/jira/browse/MESOS-9014
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the flaky test by explicitly killing the
> task before test tear-down, avoiding the race condition
> between scheduler tear-down and scheduler getting/acknowledging
> status update.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67681/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>