You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/15 16:42:26 UTC
[kudu-CR] Add release notes for tablet history GC
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3988
to review the following change.
Change subject: Add release notes for tablet history GC
......................................................................
Add release notes for tablet history GC
Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
---
M docs/release_notes.adoc
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3988/1
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add release notes for tablet history GC
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3988/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 134: Kudu will
: remove changes that were only visible prior to the ancient history mark
Nit: misplaced "only": "will remove changes that were only visible" -> "will remove only changes that were visible", or for max clarity "will remove only those changes that were visible"
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3988
to look at the new patch set (#2).
Change subject: Add release notes for tablet history GC
......................................................................
Add release notes for tablet history GC
Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
---
M docs/release_notes.adoc
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3988/2
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Add release notes for tablet history GC
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 7: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3988/6/docs/release_notes.adoc
File docs/release_notes.adoc:
PS6, Line 110: efaults to one day
update
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3988
to look at the new patch set (#4).
Change subject: Add release notes for tablet history GC
......................................................................
Add release notes for tablet history GC
Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
---
M docs/release_notes.adoc
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3988/4
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Add release notes for tablet history GC
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 5:
Build Started http://104.196.14.100/job/kudu-gerrit/3321/
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 6:
Build Started http://104.196.14.100/job/kudu-gerrit/3335/
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 7:
Build Started http://104.196.14.100/job/kudu-gerrit/3337/
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3988
to look at the new patch set (#7).
Change subject: Add release notes for tablet history GC
......................................................................
Add release notes for tablet history GC
Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
---
M docs/release_notes.adoc
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3988/7
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Add release notes for tablet history GC
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 5:
(1 comment)
is there somewhere that this also belongs in the docs?
http://gerrit.cloudera.org:8080/#/c/3988/5/docs/release_notes.adoc
File docs/release_notes.adoc:
PS5, Line 110: were only visible prior to the ancient history mark, but
: not anymore.
this reads a bit funny to me.
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3988/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 134: Kudu will
: remove changes that were only visible prior to the ancient history mark
> Definitely a nit. I think people will understand the meaning either way, so
It's tricky... updated it a little bit
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3988/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 134: Kudu will
: remove changes that were only visible prior to the ancient history mark
> Nit: misplaced "only": "will remove changes that were only visible" -> "wil
Hrm it's a little tricky but I think my wording is more correct than your suggestion. It's changes that were only visible prior to the AHM, but not anymore. Maybe I should say something like that instead. It's hard to describe succinctly.
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Add release notes for tablet history GC
......................................................................
Add release notes for tablet history GC
Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Reviewed-on: http://gerrit.cloudera.org:8080/3988
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M docs/release_notes.adoc
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Add release notes for tablet history GC
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/3218/
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 5:
> is there somewhere that this also belongs in the docs?
Yeah, I'll dig around for where to include this in the docs.
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3208/
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3988/4/docs/release_notes.adoc
File docs/release_notes.adoc:
PS4, Line 41: ,
: that
Happened to notice this typo. Probably want
"releases. Applications using" or "releases: applications using"
PS4, Line 109: Kudu will
: remove changes that were only visible prior to the ancient history mark, but
: not anymore
Maybe we need an evocative adjective to indicate "changes to the row that aren't part of the most recent / current state of the row"? Is "stale" clear enough? e.g. "Kudu will remove changes to the row that are stale and that date from before the ancient history mark". Could also define stale in a nearby sentence. Am I understanding what it's removing correctly? The term "visible" is confusing me because, to me, the state of the row at any point in the past is visible, in the sense I can ask for it and Kudu can give it to me, until there's some GC like this.
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3988/5/docs/release_notes.adoc
File docs/release_notes.adoc:
PS5, Line 110: were only visible prior to the ancient history mark, but
: not anymore.
> this reads a bit funny to me.
Will and I were discussing this in a previous rev... any suggestions?
How about:
When a compaction or flush occurs, Kudu will remove the history of changes made prior to the ancient history mark. This only affects historical data; currently-visible data will not be removed.
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3988/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 134: Kudu will
: remove changes that were only visible prior to the ancient history mark
> Hrm it's a little tricky but I think my wording is more correct than your s
Definitely a nit. I think people will understand the meaning either way, so do what you prefer.
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3988/5/docs/release_notes.adoc
File docs/release_notes.adoc:
PS5, Line 110: were only visible prior to the ancient history mark, but
: not anymore.
> Will and I were discussing this in a previous rev... any suggestions?
I think that sounds pretty good.
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Add release notes for tablet history GC
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/3314/
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2912/
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add release notes for tablet history GC
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add release notes for tablet history GC
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3988/5/docs/release_notes.adoc
File docs/release_notes.adoc:
PS5, Line 110: were only visible prior to the ancient history mark, but
: not anymore.
> I think that sounds pretty good.
Made this update
http://gerrit.cloudera.org:8080/#/c/3988/6/docs/release_notes.adoc
File docs/release_notes.adoc:
PS6, Line 110: changes that were
> update
Done
--
To view, visit http://gerrit.cloudera.org:8080/3988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1ff2322758910041732bed0c74b8a614e6d2cf2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes