You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/09 01:02:44 UTC
Review Request 61516: Fixed `check` and `tests` targets.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61516/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
Target names are being removed from variables, as they introduce
unnecessary noise.
Diffs
-----
CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5
Diff: https://reviews.apache.org/r/61516/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61516: Fixed `check` and `tests` targets.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61516/#review184467
-----------------------------------------------------------
CMakeLists.txt
Line 63 (original), 63 (patched)
<https://reviews.apache.org/r/61516/#comment260615>
Needed to add `-C $<CONFIG>` for this target to work on multi-config systems (i.e. Windows).
- Joseph Wu
On Aug. 8, 2017, 6:02 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61516/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 6:02 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-3567
> https://issues.apache.org/jira/browse/MESOS-3567
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Target names are being removed from variables, as they introduce
> unnecessary noise.
>
>
> Diffs
> -----
>
> CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5
>
>
> Diff: https://reviews.apache.org/r/61516/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61516: Fixed `check` and `tests` targets.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61516/#review184460
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 8, 2017, 6:02 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61516/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 6:02 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Target names are being removed from variables, as they introduce
> unnecessary noise.
>
>
> Diffs
> -----
>
> CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5
>
>
> Diff: https://reviews.apache.org/r/61516/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>