You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/02/20 01:28:54 UTC
Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-4660
https://issues.apache.org/jira/browse/MESOS-4660
Repository: mesos
Description
-------
Added documentation for `cgroups/net_cls` isolator.
Diffs
-----
docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
Diff: https://reviews.apache.org/r/43796/diff/
Testing
-------
Built the web-site using docker, and proof read the website and links on localhost.
Verified all the links embedded in markdown work.
Thanks,
Avinash sridharan
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/#review120025
-----------------------------------------------------------
docs/mesos-containerizer.md (lines 63 - 64)
<https://reviews.apache.org/r/43796/#comment181387>
not yours, but I think that here only need one blank line?
docs/mesos-containerizer.md (lines 85 - 86)
<https://reviews.apache.org/r/43796/#comment181388>
one blank line?
docs/mesos-containerizer.md (lines 88 - 89)
<https://reviews.apache.org/r/43796/#comment181389>
one blank line?
docs/mesos-containerizer.md (line 130)
<https://reviews.apache.org/r/43796/#comment181390>
s/state.json/state
The state.json is already deprecated.
- Guangya Liu
On 二月 20, 2016, 3:31 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43796/
> -----------------------------------------------------------
>
> (Updated 二月 20, 2016, 3:31 a.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-4660
> https://issues.apache.org/jira/browse/MESOS-4660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for `cgroups/net_cls` isolator.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
>
> Diff: https://reviews.apache.org/r/43796/diff/
>
>
> Testing
> -------
>
> Built the web-site using docker, and proof read the website and links on localhost.
>
> Verified all the links embedded in markdown work.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/#review120034
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43796]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 20, 2016, 3:31 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43796/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2016, 3:31 a.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-4660
> https://issues.apache.org/jira/browse/MESOS-4660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for `cgroups/net_cls` isolator.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
>
> Diff: https://reviews.apache.org/r/43796/diff/
>
>
> Testing
> -------
>
> Built the web-site using docker, and proof read the website and links on localhost.
>
> Verified all the links embedded in markdown work.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/#review120201
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43796]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 22, 2016, 6:26 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43796/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:26 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-4660
> https://issues.apache.org/jira/browse/MESOS-4660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for `cgroups/net_cls` isolator.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
>
> Diff: https://reviews.apache.org/r/43796/diff/
>
>
> Testing
> -------
>
> Built the web-site using docker, and proof read the website and links on localhost.
>
> Verified all the links embedded in markdown work.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/#review120950
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Feb. 22, 2016, 6:26 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43796/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:26 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-4660
> https://issues.apache.org/jira/browse/MESOS-4660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for `cgroups/net_cls` isolator.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
>
> Diff: https://reviews.apache.org/r/43796/diff/
>
>
> Testing
> -------
>
> Built the web-site using docker, and proof read the website and links on localhost.
>
> Verified all the links embedded in markdown work.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/#review120976
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 22, 2016, 6:26 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43796/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:26 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-4660
> https://issues.apache.org/jira/browse/MESOS-4660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for `cgroups/net_cls` isolator.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
>
> Diff: https://reviews.apache.org/r/43796/diff/
>
>
> Testing
> -------
>
> Built the web-site using docker, and proof read the website and links on localhost.
>
> Verified all the links embedded in markdown work.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 6:26 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-4660
https://issues.apache.org/jira/browse/MESOS-4660
Repository: mesos
Description
-------
Added documentation for `cgroups/net_cls` isolator.
Diffs (updated)
-----
docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
Diff: https://reviews.apache.org/r/43796/diff/
Testing
-------
Built the web-site using docker, and proof read the website and links on localhost.
Verified all the links embedded in markdown work.
Thanks,
Avinash sridharan
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/
-----------------------------------------------------------
(Updated Feb. 20, 2016, 3:31 a.m.)
Review request for mesos, Jie Yu and Neil Conway.
Changes
-------
Addressed Neil's reviews.
Bugs: MESOS-4660
https://issues.apache.org/jira/browse/MESOS-4660
Repository: mesos
Description
-------
Added documentation for `cgroups/net_cls` isolator.
Diffs (updated)
-----
docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
Diff: https://reviews.apache.org/r/43796/diff/
Testing
-------
Built the web-site using docker, and proof read the website and links on localhost.
Verified all the links embedded in markdown work.
Thanks,
Avinash sridharan
Re: Review Request 43796: Added documentation for `cgroups/net_cls`
isolator.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43796/#review119999
-----------------------------------------------------------
docs/mesos-containerizer.md (line 91)
<https://reviews.apache.org/r/43796/#comment181361>
I'd remove the commas here.
docs/mesos-containerizer.md (line 92)
<https://reviews.apache.org/r/43796/#comment181362>
"Mesos"
docs/mesos-containerizer.md (line 96)
<https://reviews.apache.org/r/43796/#comment181363>
"Linux"
No comma before "and"
docs/mesos-containerizer.md (line 102)
<https://reviews.apache.org/r/43796/#comment181365>
"specified"
docs/mesos-containerizer.md (line 114)
<https://reviews.apache.org/r/43796/#comment181366>
We should try to avoid link anchor text like "here"; it would be better to write a normal sentence and then link the appropriate part. e.g.,
"The [net_cls documentation](XXX) has more information on YYY..."
docs/mesos-containerizer.md (line 117)
<https://reviews.apache.org/r/43796/#comment181367>
Remove comma
docs/mesos-containerizer.md (line 118)
<https://reviews.apache.org/r/43796/#comment181369>
"net_cls handles"?
docs/mesos-containerizer.md (line 128)
<https://reviews.apache.org/r/43796/#comment181368>
Remove comma
- Neil Conway
On Feb. 20, 2016, 12:28 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43796/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2016, 12:28 a.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-4660
> https://issues.apache.org/jira/browse/MESOS-4660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for `cgroups/net_cls` isolator.
>
>
> Diffs
> -----
>
> docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296
>
> Diff: https://reviews.apache.org/r/43796/diff/
>
>
> Testing
> -------
>
> Built the web-site using docker, and proof read the website and links on localhost.
>
> Verified all the links embedded in markdown work.
>
>
> Thanks,
>
> Avinash sridharan
>
>