You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/29 19:17:43 UTC
Review Request 27341: Define MNT_DETACH for pid isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27341/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
MNT_DETACH (since Linux 2.4.11) may not be defined in older <sys/mount.h>
Diffs
-----
src/slave/containerizer/isolators/namespaces/pid.cpp 5a13a6d1249a8aca416080bcb509b703cf48d244
Diff: https://reviews.apache.org/r/27341/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 27341: Define MNT_DETACH for pid isolator.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27341/#review59024
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 29, 2014, 6:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27341/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 6:17 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MNT_DETACH (since Linux 2.4.11) may not be defined in older <sys/mount.h>
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/namespaces/pid.cpp 5a13a6d1249a8aca416080bcb509b703cf48d244
>
> Diff: https://reviews.apache.org/r/27341/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 27341: Define MNT_DETACH for pid isolator.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27341/#review59031
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27341]
All tests passed.
- Mesos ReviewBot
On Oct. 29, 2014, 6:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27341/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 6:17 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> MNT_DETACH (since Linux 2.4.11) may not be defined in older <sys/mount.h>
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/namespaces/pid.cpp 5a13a6d1249a8aca416080bcb509b703cf48d244
>
> Diff: https://reviews.apache.org/r/27341/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>