You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/05/21 21:13:25 UTC
[GitHub] incubator-guacamole-server pull request #92: GUACAMOLE-280: Add support for ...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/92
GUACAMOLE-280: Add support for faint (low) intensity SGR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server faint-sgr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit 2146200dfde612029303787d40d1f53581d77a37
Author: Michael Jumper <mj...@apache.org>
Date: 2017-05-21T20:34:30Z
GUACAMOLE-280: Add support for faint (low) intensity SGR.
commit 9da27ad5785093d18bbe85f65c3a96e26ee21816
Author: Michael Jumper <mj...@apache.org>
Date: 2017-05-21T20:48:10Z
GUACAMOLE-280: Ensure bold and half-bright attributes cancel each other out.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #92: GUACAMOLE-280: Add support for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-server/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #92: GUACAMOLE-280: Add support for ...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/92#discussion_r118809754
--- Diff: src/terminal/display.c ---
@@ -118,7 +118,7 @@ int __guac_terminal_set_colors(guac_terminal_display* display,
}
/* Handle bold */
- if (attributes->bold
+ if (attributes->bold && !attributes->half_bright
--- End diff --
I guess if both bold and half_bright are set, they cancel each other out. That makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---