[GitHub] [skywalking-kubernetes] hanahmily commented on a change in pull request #79: support secret

[GitBox <gi...@apache.org>]

hanahmily commented on a change in pull request #79:
URL: https://github.com/apache/skywalking-kubernetes/pull/79#discussion_r709041112



##########
File path: chart/skywalking/templates/es-init.job.yaml
##########
@@ -91,18 +91,39 @@ spec:
         - name: {{ $key }}
           value: {{ $value | quote }}
         {{- end }}
+        {{- range .Values.oap.secretKeyRefs }}
+        - name: {{ .name }}
+          valueFrom:
+            secretKeyRef:
+              name: {{ .secretName }}
+              key: {{ .key }}
+        {{- end }}
         volumeMounts:
           {{- if (.Files.Glob "files/conf.d/oap/**") }}
-            {{ range $path, $bytes := .Files.Glob "files/conf.d/oap/**" }}
-            - name: skywalking-oap-override
-              mountPath: {{ print "/skywalking/config/" ($path | replace "files/conf.d/oap/" "") }}
-              subPath: {{ $path | replace "files/conf.d/oap/" "" | b64enc | replace "=" "-" }}
-            {{- end }}
-            {{- end }}
+          {{ range $path, $bytes := .Files.Glob "files/conf.d/oap/**" }}
+          - name: skywalking-oap-override
+            mountPath: {{ print "/skywalking/config/" ($path | replace "files/conf.d/oap/" "") }}
+            subPath: {{ $path | replace "files/conf.d/oap/" "" | b64enc | replace "=" "-" }}
+          {{- end }}
+          {{- end }}
+          {{- range .Values.oap.secretVolumes }}
+          - name: {{ .name }}
+            readOnly: true
+            mountPath: {{ .mountPath | default "/skywalking/certs" }}

Review comment:
       defaulting to "/skywalking/certs" hints that the secret is limited to store certs and keys, how about leaving it alone?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org