You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2023/01/02 19:14:59 UTC
[GitHub] [opennlp] mawiesne opened a new pull request, #480: OPENNLP-1435 Clear typos from opennlp-docs module
mawiesne opened a new pull request, #480:
URL: https://github.com/apache/opennlp/pull/480
Change
-
- fixes typos in several dockbx files
- switches references to http URLs, if available, to a secure form (https)
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] rzo1 commented on a diff in pull request #480: OPENNLP-1435 Clear typos from opennlp-docs module
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #480:
URL: https://github.com/apache/opennlp/pull/480#discussion_r1060186417
##########
opennlp-docs/src/docbkx/corpora.xml:
##########
@@ -144,12 +144,12 @@ F-Measure: 0.9230575441395671]]>
<title>Getting the data</title>
<para>The data consists of three files per language: one training file and two test files testa and testb.
The first test file will be used in the development phase for finding good parameters for the learning system.
- The second test file will be used for the final evaluation. Currently there are data files available for two languages:
+ The second test file will be used for the final evaluation. Currently, there are data files available for two languages:
Spanish and Dutch.
</para>
<para>
The Spanish data is a collection of news wire articles made available by the Spanish EFE News Agency. The articles are
- from May 2000. The annotation was carried out by the <ulink url="http://www.talp.cat/">TALP Research Center</ulink> of the Technical University of Catalonia (UPC)
+ from May 2000. The annotation was carried out by the <ulink url="https://www.talp.cat/">TALP Research Center</ulink> of the Technical University of Catalonia (UPC)
and the <ulink url="http://clic.ub.edu/">Center of Language and Computation (CLiC)</ulink>of the University of Barcelona (UB), and funded by the European Commission
Review Comment:
http://clic.ub.edu/ is down for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] rzo1 commented on a diff in pull request #480: OPENNLP-1435 Clear typos from opennlp-docs module
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #480:
URL: https://github.com/apache/opennlp/pull/480#discussion_r1060191552
##########
opennlp-docs/src/docbkx/corpora.xml:
##########
@@ -144,12 +144,12 @@ F-Measure: 0.9230575441395671]]>
<title>Getting the data</title>
<para>The data consists of three files per language: one training file and two test files testa and testb.
The first test file will be used in the development phase for finding good parameters for the learning system.
- The second test file will be used for the final evaluation. Currently there are data files available for two languages:
+ The second test file will be used for the final evaluation. Currently, there are data files available for two languages:
Spanish and Dutch.
</para>
<para>
The Spanish data is a collection of news wire articles made available by the Spanish EFE News Agency. The articles are
- from May 2000. The annotation was carried out by the <ulink url="http://www.talp.cat/">TALP Research Center</ulink> of the Technical University of Catalonia (UPC)
+ from May 2000. The annotation was carried out by the <ulink url="https://www.talp.cat/">TALP Research Center</ulink> of the Technical University of Catalonia (UPC)
and the <ulink url="http://clic.ub.edu/">Center of Language and Computation (CLiC)</ulink>of the University of Barcelona (UB), and funded by the European Commission
Review Comment:
Not really. Maybe: [this](https://www.ub.edu/portal/web/filologia-comunicacio/centre-de-llenguatge-i-computacio-clic-) - last internet archive is from March 2022 (seems to be down a while now): http://web.archive.org/web/20220516042208/http://clic.ub.edu/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] jzonthemtn merged pull request #480: OPENNLP-1435 Clear typos from opennlp-docs module
Posted by GitBox <gi...@apache.org>.
jzonthemtn merged PR #480:
URL: https://github.com/apache/opennlp/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] mawiesne commented on a diff in pull request #480: OPENNLP-1435 Clear typos from opennlp-docs module
Posted by GitBox <gi...@apache.org>.
mawiesne commented on code in PR #480:
URL: https://github.com/apache/opennlp/pull/480#discussion_r1060188683
##########
opennlp-docs/src/docbkx/corpora.xml:
##########
@@ -144,12 +144,12 @@ F-Measure: 0.9230575441395671]]>
<title>Getting the data</title>
<para>The data consists of three files per language: one training file and two test files testa and testb.
The first test file will be used in the development phase for finding good parameters for the learning system.
- The second test file will be used for the final evaluation. Currently there are data files available for two languages:
+ The second test file will be used for the final evaluation. Currently, there are data files available for two languages:
Spanish and Dutch.
</para>
<para>
The Spanish data is a collection of news wire articles made available by the Spanish EFE News Agency. The articles are
- from May 2000. The annotation was carried out by the <ulink url="http://www.talp.cat/">TALP Research Center</ulink> of the Technical University of Catalonia (UPC)
+ from May 2000. The annotation was carried out by the <ulink url="https://www.talp.cat/">TALP Research Center</ulink> of the Technical University of Catalonia (UPC)
and the <ulink url="http://clic.ub.edu/">Center of Language and Computation (CLiC)</ulink>of the University of Barcelona (UB), and funded by the European Commission
Review Comment:
Any alternative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org